Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrated simularium file generation in combine-api #4792

Merged
merged 73 commits into from
Feb 1, 2024

Conversation

AlexPatrie
Copy link
Collaborator

@AlexPatrie AlexPatrie commented Jan 16, 2024

What does this PR do?:

  • integrates biosimulators-simularium as a dependency in apps/combine-api.
  • configures combine-api/pyproject.toml accordingly for versioning.
  • introduces a "standard" format for representing the output of spatial simulations with VTK (see the biosimulators-simularium tooling for more info)
  • implements .simularium and .vtk file generation for Smoldyn (spatial) simulation runs via biosimulators_simularium.execute() within the body of combine_api.handlers.run.handler().
  • includes aforementioned file generation in handler output for archive bundling and the creation of output.zip for all simulation runs that include Smoldyn.
  • introduces appropriate testing logic for the simularium/vtk integration.
  • performs minor CSS/style maintenance and adjustment for components throughout repo (fixes nav-button flicker, for example.)

How did you test the changes?:

  • introduced a new unittest method for smoldyn urls only.
  • pytest
  • CI/CD

@probot-autolabeler probot-autolabeler bot added BioSimulations Changes needed on the main front end platform ui labels Jan 16, 2024
Copy link

nx-cloud bot commented Jan 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f9b1ee0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@AlexPatrie AlexPatrie marked this pull request as ready for review January 26, 2024 21:05
@AlexPatrie AlexPatrie changed the title feat: consolidated dispatch and platform feat: integrated simularium file generation in combine-api Jan 26, 2024
Copy link
Collaborator

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed my comments, looks good.

apps/combine-api/tests/fixtures/Min1.txt Outdated Show resolved Hide resolved
apps/combine-api/clear-cache.sh Outdated Show resolved Hide resolved
apps/combine-api/delete-env.sh Outdated Show resolved Hide resolved
@jcschaff
Copy link
Collaborator

do you have to merge master in first? it seems to be using the master workflow scripts, and not finding simdata-api??

Copy link

gitguardian bot commented Jan 30, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9207574 Triggered Generic CLI Secret 18ea618 apps/dispatch-service/src/app/services/sbatch/expected_sbatch.ts View secret
9207574 Triggered Generic CLI Secret 18ea618 apps/dispatch-service/src/app/services/sbatch/expected_sbatch.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@probot-autolabeler probot-autolabeler bot added the docker Pull requests that update Docker code label Jan 31, 2024
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexPatrie AlexPatrie merged commit 836a53b into dev Feb 1, 2024
23 checks passed
@AlexPatrie AlexPatrie deleted the consolidate-dispatch branch February 1, 2024 18:42
@biosimulations-daemon
Copy link
Collaborator

🎉 This PR is included in version 9.56.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BioSimulations Changes needed on the main front end platform BioSimulators docker Pull requests that update Docker code released ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants