-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrated simularium file generation in combine-api #4792
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f9b1ee0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 9 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed my comments, looks good.
do you have to merge master in first? it seems to be using the master workflow scripts, and not finding simdata-api?? |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9207574 | Triggered | Generic CLI Secret | 18ea618 | apps/dispatch-service/src/app/services/sbatch/expected_sbatch.ts | View secret |
9207574 | Triggered | Generic CLI Secret | 18ea618 | apps/dispatch-service/src/app/services/sbatch/expected_sbatch.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 6 New issues |
🎉 This PR is included in version 9.56.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?:
biosimulators-simularium
as a dependency inapps/combine-api
.combine-api/pyproject.toml
accordingly for versioning..simularium
and.vtk
file generation for Smoldyn (spatial) simulation runs viabiosimulators_simularium.execute()
within the body ofcombine_api.handlers.run.handler()
.output.zip
for all simulation runs that include Smoldyn.How did you test the changes?: