Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simdata-api deployment #4794

Merged
merged 3 commits into from
Jan 26, 2024
Merged

fix: simdata-api deployment #4794

merged 3 commits into from
Jan 26, 2024

Conversation

jcschaff
Copy link
Collaborator

What new features does this PR implement?
resuses the existing path data.biosimulations.dev/org which was used by HSDS for simdata-api. This allows the TLS cert to be reused.

What bugs does this PR fix?
a cert error occurs when accessing the api externally.

@jcschaff jcschaff added the bug Something isn't working label Jan 26, 2024
@jcschaff jcschaff self-assigned this Jan 26, 2024
@probot-autolabeler probot-autolabeler bot added BioSimulations-API dependencies Pull requests that update a dependency file testing Issues relating to tests labels Jan 26, 2024
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

nx-cloud bot commented Jan 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4afcd0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@jcschaff jcschaff changed the title fix simdata-api deployment fix: simdata-api deployment Jan 26, 2024
Copy link
Collaborator

@AlexPatrie AlexPatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This needed to be done.

@jcschaff jcschaff merged commit 98d02af into dev Jan 26, 2024
24 of 25 checks passed
@jcschaff jcschaff deleted the jcs/fix-services branch January 26, 2024 19:49
@biosimulations-daemon
Copy link
Collaborator

🎉 This PR is included in version 9.55.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BioSimulations-API bug Something isn't working dependencies Pull requests that update a dependency file released testing Issues relating to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants