Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use async DynamicModule with config to initialize simdata-api path #4800

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jcschaff
Copy link
Collaborator

What new features does this PR implement?
incorporated server config into module dependency injection to initialize the correct baseUrl for simdata-api API client library. Solution was inspired by that used by combine-api, but is more compact.

What bugs does this PR fix?
communication from api service to simdata-api failed when deployed because the url was wrong.

How have you tested this PR?
tested this locally using local environment settings and running both api and simdata-api services from the IDE and platform app from browser.

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

nx-cloud bot commented Jan 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2631de5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@jcschaff jcschaff merged commit b40dcb3 into dev Jan 30, 2024
23 checks passed
@jcschaff jcschaff deleted the simdata-path-fix branch January 30, 2024 12:33
@biosimulations-daemon
Copy link
Collaborator

🎉 This PR is included in version 9.55.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants