-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented archive simulation edit for custom project rerun #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jcschaff
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, let's get this merged.
🎉 This PR is included in version 9.58.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BioSimulations
Changes needed on the main front end platform
BioSimulations-API
CI/CD
Issues with continuous integration and deployment
released
runBiosimulations
Issues pertaining to runBiosimulations frontend
simulation-service
testing
Issues relating to tests
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
(feat): implements service methods for
combine-api
withinplatform/dispatch
to render all available editable simulation parameters.(feat): creates and implements a new
shared-simulation-service
within common./libs/shared/services
to handle custom simulation re-run.(fix): refactors structure of dispatch form to hide less-used configurations in an "Advanced Settings"
mat-expansion-panel
( closes: 'run a new simulation' page needs to be redesigned #4769 )(fix): opens the
minPolicy
attributes to any level of algorithm substitution policy for the instantiation ofKisaoAlgorithmSubstitution
objects withinplatform/dispatch.component.ts
( closes: 🐛: 'run' page doesn't allow steady state substitutions #4753 )(fix): fixes project metadata get handler for all images associated with a given simulation run, and thus COMBINE/OMEX archive within
biosimulations-project-metadata.component
( closes: 'simulation specification' tab probably lying about having no image to display #4767 )How was this PR tested?:
pytest
spec.ts
for TS content