Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverside render #59

Closed
wants to merge 14 commits into from
Closed

Serverside render #59

wants to merge 14 commits into from

Conversation

bilalshaikh42
Copy link
Member

For comparison only, not to be merged

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #59 into master will increase coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage    59.9%   61.34%   +1.44%     
==========================================
  Files          97       80      -17     
  Lines        2075     1040    -1035     
  Branches      223       90     -133     
==========================================
- Hits         1243      638     -605     
+ Misses        715      372     -343     
+ Partials      117       30      -87
Flag Coverage Δ
#unittests 61.34% <ø> (+1.44%) ⬆️
Impacted Files Coverage Δ
CRBM-Viz/src/app/Shared/Services/user.service.ts 45.94% <0%> (-32.88%) ⬇️
.../src/app/Modules/user/profile/profile.component.ts 40.9% <0%> (-29.93%) ⬇️
...z/src/app/Shared/Services/visualization.service.ts 45.45% <0%> (-23.18%) ⬇️
...-Viz/src/app/Shared/Services/simulation.service.ts 53.12% <0%> (-22.48%) ⬇️
.../Modules/user/simulations/simulations.component.ts 50% <0%> (-20%) ⬇️
...iz/src/app/Modules/user/models/models.component.ts 50% <0%> (-20%) ⬇️
...ed/Components/models-grid/models-grid.component.ts 43.47% <0%> (-18.43%) ⬇️
...nts/simulations-grid/simulations-grid.component.ts 33.33% <0%> (-5.56%) ⬇️
...app/Modules/user/profile/profile-edit.component.ts 53.33% <0%> (-2.23%) ⬇️
CRBM-Viz/src/app/Shared/Models/visualization.ts 68.75% <0%> (-1.25%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a44149...8440884. Read the comment docs.

@bilalshaikh42 bilalshaikh42 marked this pull request as ready for review November 26, 2019 21:20
@bilalshaikh42 bilalshaikh42 deleted the Serverside-render branch April 24, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant