fix: solve an issue when loaddata_func is not pickle-able

biothings · May 26, 2023 · 737a9ec · 737a9ec
1 parent eaece62
commit 737a9ec
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/biothings/utils/workers.py b/biothings/utils/workers.py
@@ -41,13 +41,13 @@ def upload_worker(name, storage_class, loaddata_func, col_name, batch_size, batc
                 {
                     "exc": e,
                     "params": {"name": name, "storage_class": storage_class},
-                    "loaddata_func": loaddata_func,
+                    "loaddata_func": repr(loaddata_func),  # loaddata_func may not be pickle-able
                     "col_name": col_name,
                     "batch_size": batch_size,
                     "args": args,
                 },
                 open(pickfile, "wb"),
             )
-        except TypeError as ie:
-            logger.warning("Could not pickle batch errors: %s" % ie)
+        except (TypeError, pickle.PicklingError) as ie:
+            logger.warning("Could not pickle batch errors: %s", ie)
         raise e