refine some comments

biothings · Jul 13, 2021 · cfa77e1 · cfa77e1
1 parent a837a12
commit cfa77e1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/biothings/utils/configuration.py b/biothings/utils/configuration.py
@@ -206,7 +206,7 @@ def store_value_to_db(self, name, value):
         if name == "CONFIG_READONLY":  # False -> True also not allowed.
             raise RuntimeError("Runtime modification not allowed.")
 
-        try:
+        try:  # already json?
             json.loads(value)
         except JSONDecodeError:
             value = json.dumps(value)

diff --git a/biothings/web/handlers/query.py b/biothings/web/handlers/query.py
@@ -89,10 +89,15 @@ def prepare(self):
             # 'value': 100, # number of queries
         })
 
-    def parse_exception(self, exception):  # TODO merge this into  ESQueryPipelineHandler
+    def parse_exception(self, exception):
 
         message = super().parse_exception(exception)
 
+        # TODO merge this into ESQueryPipelineHandler
+        # or not? consider implications when we support
+        # additional discovery-like applications and
+        # eventually other than tornado web frameworks
+
         if '_es_error' in message:
             _es_error = message.pop('_es_error')
             message['error'] = _es_error.error