Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing type for node attributes #23

Closed
kevinxin90 opened this issue Feb 1, 2021 · 1 comment
Closed

Missing type for node attributes #23

kevinxin90 opened this issue Feb 1, 2021 · 1 comment
Assignees
@kevinxin90
Labels
bug Something isn't working
Milestone
Release 1.2

Comments

@kevinxin90
Copy link
Contributor

Screen Shot 2021-02-01 at 10 07 13 AM

Type is a required field for TRAPI 1.0 standard. Currently, we have type for all edge attributes, but we don't have type for node attributes.
@kevinxin90 kevinxin90 added the bug Something isn't working label Feb 1, 2021
@kevinxin90 kevinxin90 added this to the Release 1.2 milestone Feb 1, 2021
@kevinxin90 kevinxin90 self-assigned this Feb 1, 2021
kevinxin90 added a commit that referenced this issue Feb 1, 2021
@kevinxin90
fix: 🐛 fix issue regarding missing type information for node attributes
7cf6119 
#23
kevinxin90 added a commit that referenced this issue Feb 1, 2021
@kevinxin90
test: ✅ add test to check whether type is part of the node attributes
898c59e 
#23
@kevinxin90
Copy link
Contributor Author

Fixed in: 5eb3fef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinxin90 kevinxin90

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.2
Development

No branches or pull requests
1 participant
@kevinxin90