Templating revision #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… templating_revision
This was referenced Sep 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Continuation of #30 addressing #26 and biothings/biothings_explorer#147)
This PR moves all templating support to a new query builder,
template_query_builder.js. Support is improved for arbitrarily templating JSON-type request bodies.Additionally, a new filter function,
wrap, is implemented, in order to wrap a string (or strings in an array) between two strings. Takes a start an end argument, which are the strings added to the start and end of the input string. If only start is supplied, end will use the same string as start.This PR must be merged with the following additional PRs in order to work: