-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong order of entities being parsed in metakg cnstruction #39
Conversation
Note:
If this is happening for Automat TRAPI v1.2 APIs....we will likely have to be addressed in a separate issue. maybe in api-response-transform...so BTE doesn't keep records from Automat APIs where its predicate field =/= the smartapi metadata predicate Example: POST to https://automat.renci.org/covidkopkg/1.1/query. Even though the query given used the "related_to" predicate, all the edges actually have correlated_with edges. BTE will take something like this and assume all the edges have the "related_to" predicate when they actually dont'...
|
Re-review of BTE's ability to query Automat APIs is described (the previous review was here). The APIs being called by these queries have changed:
These queries now get results from the APIs:
Not getting results from example queries for:
|
My suggestion is to merge / push to prod ASAP. Also, automated testing is passing on my local for this particular module's tests. Noting though:
|
We also expand the predicate filter I think, so if they expand it I don't think that's a problem is it? if we both have correlated_to as the predicate it should get results if I'm right |
In that above example, the problem is that we are querying their API both for related_to edges and correlated_with edges...and getting the same data set for both and not recognizing that they're the same. We are instead saying there's a set of edges with related_to + a set of edges with correlated_with... |
Looks like TRAPI v1.2 APIs might not actually do this...so it's not a problem. |
MetaKG construction is creating operations with object/subject in the wrong order going against the pattern that they are stored in the file being read. This PR fixes that order and correctly gets results from previously not working queries.