Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Get rid of the resources folder #83

Closed
SheepFromHeaven opened this issue Jan 21, 2019 · 3 comments
Closed

RFC: Get rid of the resources folder #83

SheepFromHeaven opened this issue Jan 21, 2019 · 3 comments
Assignees

Comments

@SheepFromHeaven
Copy link
Member

I propose to get rid of the resources folder, as everything should live inside a component to guaranty reusability. This ticket is for discussion around that topic and for collection of risks.

@SheepFromHeaven
Copy link
Member Author

Q: What about global styles?

@SheepFromHeaven
Copy link
Member Author

Q: What about icontfonts/SVG sprites?

@jurekbarth
Copy link
Collaborator

I think the resources folder could be removed but still there's a need for some folder structure for helpers. Something like lodash but more customized.

SVG Sprites could be a web component rendering that icon for you. We would need a svg loader and then they would be bundled with a little bit of js. For usage in CSS we could start with including single items, so an SVG Sprite would make sense here.

Global Styles: I would like to try out what styled-component does in React. They have a theme component that does global styles as well as variables. --> here we could progressively enhance with css custom properties. So we could change styles at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants