Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add connect-port to projectConfig #146

Merged
merged 3 commits into from
Aug 16, 2019
Merged

add connect-port to projectConfig #146

merged 3 commits into from
Aug 16, 2019

Conversation

luke-m
Copy link

@luke-m luke-m commented Aug 16, 2019

fixes #145

@luke-m luke-m requested a review from timomayer August 16, 2019 09:33
@timomayer
Copy link
Member

thank @luke-m
why do you think the port should be in projectConfig? i prefr to have as less things as possible in projectConfig and if you need them in a project you can add them.

@luke-m
Copy link
Author

luke-m commented Aug 16, 2019

Hmm well to me it wasn't obvious that it was even possible to do it.
At first I found out you could change the port directly in biotope-build's config.
Then I found out that you could override that with the projectConfig.
But this required me to look into how build works and uses the config etc.
So to me it would've made it more obvious that it is possible at all, if such an entry would be in the projectConfig by default.
I just checked the documentation for projectConfig, and there it doesn't explain that the whole content gets merged into build's config. Here the wording suggests that only the things that are specified are configurable.
So IMO we either need to add the port to the default projectConfig to make it obvious that it's configurable or we need to reword the documentation to reflect the fact that it's possible to override everything in the build-config.

@luke-m
Copy link
Author

luke-m commented Aug 16, 2019

i prefr to have as less things as possible in projectConfig and if you need them in a project you can add them

I don't necessarily share this point of view. IMO if the projectConfig is well documented, it helps the user a lot to understand what he/she can configure and what not. Or why do you think that there should me as little entries as possible?

@timomayer
Copy link
Member

@luke-m i agree we have to improve the projectConfig documentation! if we have everything by default in the projectConfig and we change things with biotope-build updates it is a lot more things you have to manually update compared to if every project just has a few lines in the projectConfig which are really important for this project

@luke-m
Copy link
Author

luke-m commented Aug 16, 2019

@timomayer check again please. I added a comment explaining the purpose of projectConfig.js and removed the connect-port.

@timomayer timomayer requested a review from a team August 16, 2019 10:52
@timomayer timomayer merged commit 606302d into master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make port configurable in projectConfig
2 participants