[⚠️ Needs testing]Feature/biotope element #79
Conversation
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| <!-- build:js(.tmp) resources/js/scripts.head.all.min.js --> | |||
There was a problem hiding this comment.
We need polyfills for IE11 for promises, fetch and Object.assign
<script nomodule src="resources/js/polyfills/object-assign.polyfill.js"></script>
<script nomodule src="https://cdn.jsdelivr.net/npm/whatwg-fetch@3.0.0/dist/fetch.umd.min.js"></script>
<script nomodule src="https://cdn.jsdelivr.net/npm/promise-polyfill@8/dist/polyfill.min.js"></script>
There was a problem hiding this comment.
@jurekbarth shouldn't we also fetch the object assign polyfill from a cdn?
There was a problem hiding this comment.
@SheepFromHeaven i'm fine with both versions, this was just an example. Depending on the use-case both versions have its pros and cons. Sorry for the confusion using both possibilities 🙃We should start docs to document the polyfills folder btw.
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| <!-- build:js(.tmp) resources/js/scripts.head.all.min.js --> | |||
| <script src="resources/js/vendor/modernizr.js"></script> | |||
| <script src="https://unpkg.com/@webcomponents/webcomponentsjs@2.2.1/webcomponents-loader.js"></script> | |||
| <script nomodule src="https://cdn.jsdelivr.net/npm/whatwg-fetch@3.0.0/dist/fetch.umd.min.js"></script> | |||
There was a problem hiding this comment.
Could we use unpkg here aswell? And one other argument for a local version: working offline, that would be a really nice to have for me
| } else { | ||
| biotope.configuration.set('biotope.IE', false); | ||
| } | ||
|
|
||
| // better touch detection | ||
| biotope.configuration.set('biotope.touch', (Modernizr.touch || 'ontouchstart' in window || navigator.MaxTouchPoints > 0 || navigator.msMaxTouchPoints > 0)); | ||
| biotope.configuration.set('biotope.touch', (Modernizr.touchevents || 'ontouchstart' in window || navigator.maxTouchPoints > 0 || navigator.msMaxTouchPoints > 0)); |
There was a problem hiding this comment.
Is that the up to date version? pointer-events with fallback for Safari would be the way to go i guess.
After cloning this version, one is able to use biotope element.
resolves #76