Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong filename in generated page #50

Closed
luke-m opened this issue Aug 5, 2019 · 0 comments · Fixed by #51
Closed

Wrong filename in generated page #50

luke-m opened this issue Aug 5, 2019 · 0 comments · Fixed by #51

Comments

@luke-m
Copy link

luke-m commented Aug 5, 2019

Wrong filename in generated page
The generated path in the page looks like:
contentMain="components/XHeroeNumber/scaffolding/demo"

But in the scaffolding folder a file with the component name is generated.

Expected behavior
The CLI tool generates the path with the hbs filename:
contentMain="components/XHeroeNumber/scaffolding/XHeroeNumber"

Copied from here.

luke-m pushed a commit to biotope/website that referenced this issue Aug 5, 2019
There's a bug in biotope-generate, that needed to be fixed here.
biotope/biotope-generator#50
clemensf pushed a commit to biotope/website that referenced this issue Oct 18, 2019
* init biotope instance

* docs(readme.md): init README for project

Previously, the README was the default for biotope-boilerplate. Now it's a custom one for the
website-project.

* feat: add commitizen

Added CLI tool commitizen as commit standard for the project.

* feat: remove jekyll config

Removed Jekyll configuration file. This site will no longer use Jekyll.

BREAKING CHANGE: Site will no longer work with GitHub Pages

* feat: add BioButton component

First componenent, mostly to get started.

* fix: change path to component inside page file

There's a bug in biotope-generate, that needed to be fixed here.
biotope/biotope-generator#50

* fix: change version of biotope-build to temporary fix branch

There's a bug in biotope-build. I uncommented the faulty gulp-task in a branch and reference this
branch here.

* fix: change to biotope-build 0.6.2

'next' and 7.0.0 seem to be broken

BREAKING CHANGE: npm install required

* fix: use temporary biotope-build branch to fix build

* fix: add empty hbs file, revert to build 6.2.0

There's a bug in biotope: when you don't have any client-side templates yet (src/resources/hbs), the
build breaks. Adding a file there fixes it.

* revert: revert back to build next

* fix: try resource loader relative path

* fix: add / to staticResources

* fix: biotope-build v7.1.0-2

* chore: add .vscode to .gitignore

* feat: add placeholder header and footer

* biotope website:
- updated biotope-build and biotope-element to latest versions
- updated node engine to 10.16.1 (LTS)
- npm audit fix

* biotope website:
- re-structured the content template: moved everything in content.main.hbs

* add basic first section, add github corner component, clean up

* remove console.log

* add placeholder buttons

* extrapolate styling of github corner to seperate css fle

* #23 button component (#28)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* Luke m patch 1 (#29)

* Update nodejs.yml

* add gitignore, delete workflow

* Create test.yml

* ci(workflow): testing the github workflow

* #23 button component (#31)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* workflow testing

* remove install & build to make workflow testing quicker

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* 24 create benefit component (#32)

* feat: init BioBenefits

re #24

* feat(biobenefit): add BioBenefit, BioHeadline etc

re #14, re #24

* add headline & paragraph

* disabled workflow

* workflow test

* #23 button component (#34)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* workflow testing

* workflow testing

* footer done for mobile and desktop (#30)

* footer done for mobile and desktop

* merged develop, changed placeholder button to bio-button in footer

* moved some font styling to _types, changed to @include breakpoints, cleaning

* just changed button modifiers

* added swoosh to header, changed layout for benefits section to be the parent of row and col

* #23 button component (#35)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* change naming of swoosh

* adjust benefits section to pre-timo design

* 18 extended benefits (#38)

* add swoosh to section & changes to swoosh

* remove modifier

* working version of extended benefits

* 19 customer reference (#39)

* add swoosh to section & changes to swoosh

* remove modifier

* working version of extended benefits

* finish company section

* feat(company-section): add alt tags for company logos

* style(global.scss): code review changes

* 40 rework swoosh (#41)

* fix: remove old swoosh

re #40

* fix: remove swoosh from css

re #40

* fix: add new swoosh

fixes #40

* refactor(swoosh): remove old swoosh css

* refactor(swoosh): remove alternative implementation of new swoosh

* style(swoosh): change order of css attributes

* refactor(swoosh): update variables + variable usage

* feat(global-style): adjusted some stylings (splash bg, positioning)

* feat(buttons): add button with orange gradient

* fix(buttons): make outline of button white

* 15 implement scroll animated section (#33)

* BioScrollAnimation:
- implented component for scroll enabled animation using scrollMagic with gsap and bodymovin
- add missing files
- refactored function names of BioScrollAnimation.ts
- use const where appropriate
- markup: changed section id to class name
- updated BioScrollAnimation to be consistent with newer components created with biotope generate 2.0.0

- reduced number of option props in interface
- added animation.json from Joachim Roschka
- removed demo animation data
- use Lottie instead of bodymovin to load and render animation
- load animation via path with lottie instead of javascript fetch
- disable scroll indicators of ScrollMagic
- fixed responsive sizing of svg animation
- added SEO text to bio-scroll-animation section
- cleanup

* #23 button component (#44)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* button sizing adjustments

* added url param to buttons

* grid improvements for footer

* 17 resources section (#43)

* created BioRsource component started mobile implementation

* finish resources section for desktop and tablet. button adjustments required from button branch

* padding adjustments to make content visible

* resources layout cleanup

* PR changes and small cleaning in styles

* #1 splash screen section header (#48)

* desktop slpash adjustments

* removing comments

* 15 implement scroll animated section (#45)

* biotope website:
- implented component for scroll enabled animation using scrollMagic with gsap and bodymovin

* biotope website:
- add missing files

* workflow testing

* workflow testing

* remove workflow

* biotope website:
- refactored function names of BioScrollAnimation.ts
- use const where appropriate
- markup: changed section id to class name

* biotope website:
- updated BioScrollAnimation to be consistent with newer components created with biotope generate 2.0.0

* biotope website, BioScrollAnimation:
- reduced number of option props in interface
- added animation.json from Joachim Roschka
- removed demo animation data
- use Lottie instead of bodymovin to load and render animation
- load animation via path with lottie instead of javascript fetch
- disable scroll indicators of ScrollMagic
- fixed responsive sizing of svg animation
- added SEO text to bio-scroll-animation section

* biotope website, BioScrollAnimation: cleanup

* biotope website, BioScrollAnimation:
- implemented automatic "snap to slides" instead of a linear scroll animation.
- updated animation data from Jogi (but still not final! issue: animation slides are not of equal duration)
- updated SEO text in scaffolding

* biotope website, BioScrollAnimation:
- updated animation data from Jogi (but still not final! issue: animation slides are not of equal duration)

* biotope website, BioScrollAnimation:
- added dynamic ans interactive slide controls
- new markup and data structure for slides
- generic creation of slides data structure based on sections in markup
- removed obsolete props and attributes
- dispatch custom event 'bioScrollAnimation.showSlide', required for tracking
- fixed width of animation-wrapper

* biotope website, BioScrollAnimation:
- made code for getting title of slide more robust
- remeoved obsolete comment

* fix(biobutton): fix button triggering a redirect when it doesn't have a URL

* created soEasySection (#47)

* created soEasySection

* text adjustments and spacing improvements

* header adjustment

* cleaning

* 15 implement scroll animated section (#51)

- fixed automatic scrolling issues after window resize
- fixed animation-container width to correctly resize to the window's with

* reaplied soEasy section back in

* #23 button component (#53)

* added button functionality to buttons with # and buttons with links

* updated latest animation data and text (#55)

optimized position of slide controls

* implemented "Want to know more" section (#54)

* implemented "Whant to know more" section with call to action button with mailto link

* removed obsolete scss import

* fixed typo

* 9 tracking (#50)

* adding tracking

* adjusted naming, meged develop

* improved tracking script

* removed unecessary package @types/google.analytics

* adapting extended benefits sizing (#56)

* #23 button component (#57)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* button sizing adjustments

* added url param to buttons

* added button functionality to buttons with # and buttons with links

* cleaning

* PR changes

* improving button styling

* fixed javascript error this.props.url is undefined or null

* 42 whos behind biotope (#49)

* feat(biomodal): implement first steps of bioModal

re #42

* feat(biomodal): fully implement modal

* feat(whosbehind): adjustments to modal, implement bioCollaboratorList

re #42

* chore: merge develop branch

clean out merge conflicts

* improved css like Ivaylo suggested

* feat(compatibility): add IE11 polyfills

* refactor: remove unused components and delete bioHeadline

bioHeadline is unnecessarily complicated for something that we can do with native html elements.

* github corner color fix

* removing free icon, applying new 100% open source icon and adding text for benefits section

* 16 so easy section (#61)

* created soEasySection

* text adjustments and spacing improvements

* 9 tracking (#58)

* adding tracking

* adjusted naming, meged develop

* improved tracking script

* removed unecessary package @types/google.analytics

* Implement tracking: internal/external links, mailto links and modal links

* 18 extended benefits (#62)

Text Changes and icons

* 42 whos behind biotope - IMPLEMENT DESIGN (#59)

* feat(biomodal): implement first steps of bioModal

re #42

* feat(biomodal): fully implement modal

* feat(whosbehind): adjustments to modal, implement bioCollaboratorList

re #42

* chore: merge develop branch

clean out merge conflicts

* improved css like Ivaylo suggested

* feat(whosbehind): implement design, remove tab implmentation

re #42

* refactor(biomodal): remove references to delete component

* fix(biomodal): add bioCollaboratorTile to bioModal dependencies

* minor changes

* splash header section changes and optimization for IE1 (#60)

* splash header section changes and optimization for IE1

* changed button link position

* 17 resources section (#63)

* created BioRsource component started mobile implementation

* finish resources section for desktop and tablet. button adjustments required from button branch

* padding adjustments to make content visible

* resources layout cleanup

* PR changes and small cleaning in styles

* design QA up till resource section

* Design QA final feedback to be applied

* 40 rework swoosh (#64)

* Implement new swoosh component

* add new swoosh component to footer
fix position and padding of sections for swoosh

* fixed scss variable name

* 9 tracking update (#66)

- implemented scroll tracking
- modified main sections for tracking: added ids and updated ids and classNames (for consistency)
- link tracking: track href instead of link text or title

* paragraph color readjustings, General stying, Removing of paragraph component

* center sections adjust claim intro, adjust font for splash claim

* 67 seo use h3 headlines instead of biosectionheadline component (#68)

 SEO fix: use proper h1- h4 headline structure
optimized headline styles

* refactor easy setup component structure

* spelling corrections

* spelling changes v2

* move animation.json to _assets

* modal: optimized position of close button

* bio-swoosh: fixed IE11 and Edge SVG rendering issues

* chore(polyfills): remove duplicate script tags

There were script tags to get polyfills that were already implemented somewhere else before.

* 70 ie11grid fix (#78)

* fixed inverted color text for bio-benefits, fixed grid sizing for StartBuildingWithinMinutes

* fix for bio-benefits image height on safari

* screen overlaping fix for splash screen

*  smooth scrollig effect on buttons (#103)

* 80 update collab list (#100)

* feat(bio-collaborators): add collaborators to list

* feat(bio-collaborators): add collaborators to list

* refactor(collaborators): code review clean up

* feat(biocollaborators): add missing github links

* feat(biocollaborator): add iamge for tiago, change hover pointer

* 71 cookiebanner (#97)

* feat(cookiebanner): add cookiebanner

re #71

* feat(cookiebanner): change text

* feat(cookiebanner): finish cookiebanner functionality

initialize GTM & GA only after user pressed accept, remove cookies when user presses decline etc

re #71 re #96

* fix(biocookiebanner): fix mobile styles

* refactor(biocookiebanner): remove test id

* feat(biocookiebanner): make buttons white (#111)

* cookie banner readability improvement, mobile adjustments

* text readability <br> change

* text changes - Biotope consistency, Favicon, title, Description, link adjustments, removed knowMore section (#101)

* feat(fonts): remove google fonts link, self-host fonts (#110)

#108

* Privacy policy added, link styling applied (#112)

* fixed safari bloated code examples and made adjustments for chrome accordingly (#113)

* nesting fix for bloated fix

* spelling misstakes taken care of

* using a timeout prevents iOS Safari from executing scroll handler before accelerated scrolling really is finished (#114)

* cleaning, cookie banner decline options, spelling misstakes

* cleaning, text changes for privacy policy, cookie banner text

* 81 update animation seo text (#115)

* update animation and SEO text.

* dynamically set aspectRatio handling, still needs improvement.

* removed dynamically aspectRatio handling, updated animation data instead.

* cleanup and small iOS fix for swoosh

* svg sizing for good company logos

* collaborators: set missing height of github profile images (#118)

* added 24 months as LinkedIn campaign time instead of ?

* : to . change

* text changes and adjustments

* 127 privacy policy link in cookie banner (#128)

* refactor part of cookie banner to accept slotted P text so that we can use a link to PrivacyPolicy

* cleaning

* cleaning

* Updated the animation.json and the texts in the corresponding component. (#130)

* 131 improve set up sec (#137)

* installation section adjustments

* mobile cookie banner adjustments (#136)

* mobile cookie banner adjustments

* swoosh: improved margin feature (#138)

* Biowebsite ci cd (#139)

* Create biowebsiteCICD.yml
* initial biotope website cd workflow
luke-m pushed a commit to biotope/website that referenced this issue Oct 22, 2019
* init biotope instance

* docs(readme.md): init README for project

Previously, the README was the default for biotope-boilerplate. Now it's a custom one for the
website-project.

* feat: add commitizen

Added CLI tool commitizen as commit standard for the project.

* feat: remove jekyll config

Removed Jekyll configuration file. This site will no longer use Jekyll.

BREAKING CHANGE: Site will no longer work with GitHub Pages

* feat: add BioButton component

First componenent, mostly to get started.

* fix: change path to component inside page file

There's a bug in biotope-generate, that needed to be fixed here.
biotope/biotope-generator#50

* fix: change version of biotope-build to temporary fix branch

There's a bug in biotope-build. I uncommented the faulty gulp-task in a branch and reference this
branch here.

* fix: change to biotope-build 0.6.2

'next' and 7.0.0 seem to be broken

BREAKING CHANGE: npm install required

* fix: use temporary biotope-build branch to fix build

* fix: add empty hbs file, revert to build 6.2.0

There's a bug in biotope: when you don't have any client-side templates yet (src/resources/hbs), the
build breaks. Adding a file there fixes it.

* revert: revert back to build next

* fix: try resource loader relative path

* fix: add / to staticResources

* fix: biotope-build v7.1.0-2

* chore: add .vscode to .gitignore

* feat: add placeholder header and footer

* biotope website:
- updated biotope-build and biotope-element to latest versions
- updated node engine to 10.16.1 (LTS)
- npm audit fix

* biotope website:
- re-structured the content template: moved everything in content.main.hbs

* add basic first section, add github corner component, clean up

* remove console.log

* add placeholder buttons

* extrapolate styling of github corner to seperate css fle

* #23 button component (#28)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* Luke m patch 1 (#29)

* Update nodejs.yml

* add gitignore, delete workflow

* Create test.yml

* ci(workflow): testing the github workflow

* #23 button component (#31)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* workflow testing

* remove install & build to make workflow testing quicker

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* 24 create benefit component (#32)

* feat: init BioBenefits

re #24

* feat(biobenefit): add BioBenefit, BioHeadline etc

re #14, re #24

* add headline & paragraph

* disabled workflow

* workflow test

* #23 button component (#34)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* workflow testing

* workflow testing

* footer done for mobile and desktop (#30)

* footer done for mobile and desktop

* merged develop, changed placeholder button to bio-button in footer

* moved some font styling to _types, changed to @include breakpoints, cleaning

* just changed button modifiers

* added swoosh to header, changed layout for benefits section to be the parent of row and col

* #23 button component (#35)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* change naming of swoosh

* adjust benefits section to pre-timo design

* 18 extended benefits (#38)

* add swoosh to section & changes to swoosh

* remove modifier

* working version of extended benefits

* 19 customer reference (#39)

* add swoosh to section & changes to swoosh

* remove modifier

* working version of extended benefits

* finish company section

* feat(company-section): add alt tags for company logos

* style(global.scss): code review changes

* 40 rework swoosh (#41)

* fix: remove old swoosh

re #40

* fix: remove swoosh from css

re #40

* fix: add new swoosh

fixes #40

* refactor(swoosh): remove old swoosh css

* refactor(swoosh): remove alternative implementation of new swoosh

* style(swoosh): change order of css attributes

* refactor(swoosh): update variables + variable usage

* feat(global-style): adjusted some stylings (splash bg, positioning)

* feat(buttons): add button with orange gradient

* fix(buttons): make outline of button white

* 15 implement scroll animated section (#33)

* BioScrollAnimation:
- implented component for scroll enabled animation using scrollMagic with gsap and bodymovin
- add missing files
- refactored function names of BioScrollAnimation.ts
- use const where appropriate
- markup: changed section id to class name
- updated BioScrollAnimation to be consistent with newer components created with biotope generate 2.0.0

- reduced number of option props in interface
- added animation.json from Joachim Roschka
- removed demo animation data
- use Lottie instead of bodymovin to load and render animation
- load animation via path with lottie instead of javascript fetch
- disable scroll indicators of ScrollMagic
- fixed responsive sizing of svg animation
- added SEO text to bio-scroll-animation section
- cleanup

* #23 button component (#44)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* button sizing adjustments

* added url param to buttons

* grid improvements for footer

* 17 resources section (#43)

* created BioRsource component started mobile implementation

* finish resources section for desktop and tablet. button adjustments required from button branch

* padding adjustments to make content visible

* resources layout cleanup

* PR changes and small cleaning in styles

* #1 splash screen section header (#48)

* desktop slpash adjustments

* removing comments

* 15 implement scroll animated section (#45)

* biotope website:
- implented component for scroll enabled animation using scrollMagic with gsap and bodymovin

* biotope website:
- add missing files

* workflow testing

* workflow testing

* remove workflow

* biotope website:
- refactored function names of BioScrollAnimation.ts
- use const where appropriate
- markup: changed section id to class name

* biotope website:
- updated BioScrollAnimation to be consistent with newer components created with biotope generate 2.0.0

* biotope website, BioScrollAnimation:
- reduced number of option props in interface
- added animation.json from Joachim Roschka
- removed demo animation data
- use Lottie instead of bodymovin to load and render animation
- load animation via path with lottie instead of javascript fetch
- disable scroll indicators of ScrollMagic
- fixed responsive sizing of svg animation
- added SEO text to bio-scroll-animation section

* biotope website, BioScrollAnimation: cleanup

* biotope website, BioScrollAnimation:
- implemented automatic "snap to slides" instead of a linear scroll animation.
- updated animation data from Jogi (but still not final! issue: animation slides are not of equal duration)
- updated SEO text in scaffolding

* biotope website, BioScrollAnimation:
- updated animation data from Jogi (but still not final! issue: animation slides are not of equal duration)

* biotope website, BioScrollAnimation:
- added dynamic ans interactive slide controls
- new markup and data structure for slides
- generic creation of slides data structure based on sections in markup
- removed obsolete props and attributes
- dispatch custom event 'bioScrollAnimation.showSlide', required for tracking
- fixed width of animation-wrapper

* biotope website, BioScrollAnimation:
- made code for getting title of slide more robust
- remeoved obsolete comment

* fix(biobutton): fix button triggering a redirect when it doesn't have a URL

* created soEasySection (#47)

* created soEasySection

* text adjustments and spacing improvements

* header adjustment

* cleaning

* 15 implement scroll animated section (#51)

- fixed automatic scrolling issues after window resize
- fixed animation-container width to correctly resize to the window's with

* reaplied soEasy section back in

* #23 button component (#53)

* added button functionality to buttons with # and buttons with links

* updated latest animation data and text (#55)

optimized position of slide controls

* implemented "Want to know more" section (#54)

* implemented "Whant to know more" section with call to action button with mailto link

* removed obsolete scss import

* fixed typo

* 9 tracking (#50)

* adding tracking

* adjusted naming, meged develop

* improved tracking script

* removed unecessary package @types/google.analytics

* adapting extended benefits sizing (#56)

* #23 button component (#57)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* button sizing adjustments

* added url param to buttons

* added button functionality to buttons with # and buttons with links

* cleaning

* PR changes

* improving button styling

* fixed javascript error this.props.url is undefined or null

* 42 whos behind biotope (#49)

* feat(biomodal): implement first steps of bioModal

re #42

* feat(biomodal): fully implement modal

* feat(whosbehind): adjustments to modal, implement bioCollaboratorList

re #42

* chore: merge develop branch

clean out merge conflicts

* improved css like Ivaylo suggested

* feat(compatibility): add IE11 polyfills

* refactor: remove unused components and delete bioHeadline

bioHeadline is unnecessarily complicated for something that we can do with native html elements.

* github corner color fix

* removing free icon, applying new 100% open source icon and adding text for benefits section

* 16 so easy section (#61)

* created soEasySection

* text adjustments and spacing improvements

* 9 tracking (#58)

* adding tracking

* adjusted naming, meged develop

* improved tracking script

* removed unecessary package @types/google.analytics

* Implement tracking: internal/external links, mailto links and modal links

* 18 extended benefits (#62)

Text Changes and icons

* 42 whos behind biotope - IMPLEMENT DESIGN (#59)

* feat(biomodal): implement first steps of bioModal

re #42

* feat(biomodal): fully implement modal

* feat(whosbehind): adjustments to modal, implement bioCollaboratorList

re #42

* chore: merge develop branch

clean out merge conflicts

* improved css like Ivaylo suggested

* feat(whosbehind): implement design, remove tab implmentation

re #42

* refactor(biomodal): remove references to delete component

* fix(biomodal): add bioCollaboratorTile to bioModal dependencies

* minor changes

* splash header section changes and optimization for IE1 (#60)

* splash header section changes and optimization for IE1

* changed button link position

* 17 resources section (#63)

* created BioRsource component started mobile implementation

* finish resources section for desktop and tablet. button adjustments required from button branch

* padding adjustments to make content visible

* resources layout cleanup

* PR changes and small cleaning in styles

* design QA up till resource section

* Design QA final feedback to be applied

* 40 rework swoosh (#64)

* Implement new swoosh component

* add new swoosh component to footer
fix position and padding of sections for swoosh

* fixed scss variable name

* 9 tracking update (#66)

- implemented scroll tracking
- modified main sections for tracking: added ids and updated ids and classNames (for consistency)
- link tracking: track href instead of link text or title

* paragraph color readjustings, General stying, Removing of paragraph component

* center sections adjust claim intro, adjust font for splash claim

* 67 seo use h3 headlines instead of biosectionheadline component (#68)

 SEO fix: use proper h1- h4 headline structure
optimized headline styles

* refactor easy setup component structure

* spelling corrections

* spelling changes v2

* move animation.json to _assets

* modal: optimized position of close button

* bio-swoosh: fixed IE11 and Edge SVG rendering issues

* chore(polyfills): remove duplicate script tags

There were script tags to get polyfills that were already implemented somewhere else before.

* 70 ie11grid fix (#78)

* fixed inverted color text for bio-benefits, fixed grid sizing for StartBuildingWithinMinutes

* fix for bio-benefits image height on safari

* screen overlaping fix for splash screen

*  smooth scrollig effect on buttons (#103)

* 80 update collab list (#100)

* feat(bio-collaborators): add collaborators to list

* feat(bio-collaborators): add collaborators to list

* refactor(collaborators): code review clean up

* feat(biocollaborators): add missing github links

* feat(biocollaborator): add iamge for tiago, change hover pointer

* 71 cookiebanner (#97)

* feat(cookiebanner): add cookiebanner

re #71

* feat(cookiebanner): change text

* feat(cookiebanner): finish cookiebanner functionality

initialize GTM & GA only after user pressed accept, remove cookies when user presses decline etc

re #71 re #96

* fix(biocookiebanner): fix mobile styles

* refactor(biocookiebanner): remove test id

* feat(biocookiebanner): make buttons white (#111)

* cookie banner readability improvement, mobile adjustments

* text readability <br> change

* text changes - Biotope consistency, Favicon, title, Description, link adjustments, removed knowMore section (#101)

* feat(fonts): remove google fonts link, self-host fonts (#110)

#108

* Privacy policy added, link styling applied (#112)

* fixed safari bloated code examples and made adjustments for chrome accordingly (#113)

* nesting fix for bloated fix

* spelling misstakes taken care of

* using a timeout prevents iOS Safari from executing scroll handler before accelerated scrolling really is finished (#114)

* cleaning, cookie banner decline options, spelling misstakes

* cleaning, text changes for privacy policy, cookie banner text

* 81 update animation seo text (#115)

* update animation and SEO text.

* dynamically set aspectRatio handling, still needs improvement.

* removed dynamically aspectRatio handling, updated animation data instead.

* cleanup and small iOS fix for swoosh

* svg sizing for good company logos

* collaborators: set missing height of github profile images (#118)

* added 24 months as LinkedIn campaign time instead of ?

* : to . change

* text changes and adjustments

* 127 privacy policy link in cookie banner (#128)

* refactor part of cookie banner to accept slotted P text so that we can use a link to PrivacyPolicy

* cleaning

* cleaning

* Updated the animation.json and the texts in the corresponding component. (#130)

* 131 improve set up sec (#137)

* installation section adjustments

* mobile cookie banner adjustments (#136)

* mobile cookie banner adjustments

* swoosh: improved margin feature (#138)

* Biowebsite ci cd (#139)

* Create biowebsiteCICD.yml
* initial biotope website cd workflow

* resources section set URL of read docs button (#144)

set the URL of the second read docs button in the resources section to the same URL as the one in the splash screen section:

https://github.com/biotope/biotope/blob/master/docs/quickstart.md

* feat(tracking): add tracking for github links (#148)

* fix(company-logos): fix size/distortion of company logos (#149)

fix #147

* collaborator modal: fixed z-index and github links clickable area (#143)

* changing favicon sizing to 1024 (#156)

* changing favicon sizing to 1024

* fix(favicons): fix favicons path

#140

* fix(favicons): fix favicons path

forgot an 's'

#140

* Changing the contact buttons to links (#155)
IvailoStoyanov added a commit to biotope/website that referenced this issue Jan 14, 2020
* init biotope instance

* docs(readme.md): init README for project

Previously, the README was the default for biotope-boilerplate. Now it's a custom one for the
website-project.

* feat: add commitizen

Added CLI tool commitizen as commit standard for the project.

* feat: remove jekyll config

Removed Jekyll configuration file. This site will no longer use Jekyll.

BREAKING CHANGE: Site will no longer work with GitHub Pages

* feat: add BioButton component

First componenent, mostly to get started.

* fix: change path to component inside page file

There's a bug in biotope-generate, that needed to be fixed here.
biotope/biotope-generator#50

* fix: change version of biotope-build to temporary fix branch

There's a bug in biotope-build. I uncommented the faulty gulp-task in a branch and reference this
branch here.

* fix: change to biotope-build 0.6.2

'next' and 7.0.0 seem to be broken

BREAKING CHANGE: npm install required

* fix: use temporary biotope-build branch to fix build

* fix: add empty hbs file, revert to build 6.2.0

There's a bug in biotope: when you don't have any client-side templates yet (src/resources/hbs), the
build breaks. Adding a file there fixes it.

* revert: revert back to build next

* fix: try resource loader relative path

* fix: add / to staticResources

* fix: biotope-build v7.1.0-2

* chore: add .vscode to .gitignore

* feat: add placeholder header and footer

* biotope website:
- updated biotope-build and biotope-element to latest versions
- updated node engine to 10.16.1 (LTS)
- npm audit fix

* biotope website:
- re-structured the content template: moved everything in content.main.hbs

* add basic first section, add github corner component, clean up

* remove console.log

* add placeholder buttons

* extrapolate styling of github corner to seperate css fle

* #23 button component (#28)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* Luke m patch 1 (#29)

* Update nodejs.yml

* add gitignore, delete workflow

* Create test.yml

* ci(workflow): testing the github workflow

* #23 button component (#31)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* workflow testing

* remove install & build to make workflow testing quicker

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* workflow testing

* 24 create benefit component (#32)

* feat: init BioBenefits

re #24

* feat(biobenefit): add BioBenefit, BioHeadline etc

re #14, re #24

* add headline & paragraph

* disabled workflow

* workflow test

* #23 button component (#34)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* workflow testing

* workflow testing

* footer done for mobile and desktop (#30)

* footer done for mobile and desktop

* merged develop, changed placeholder button to bio-button in footer

* moved some font styling to _types, changed to @include breakpoints, cleaning

* just changed button modifiers

* added swoosh to header, changed layout for benefits section to be the parent of row and col

* #23 button component (#35)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* change naming of swoosh

* adjust benefits section to pre-timo design

* 18 extended benefits (#38)

* add swoosh to section & changes to swoosh

* remove modifier

* working version of extended benefits

* 19 customer reference (#39)

* add swoosh to section & changes to swoosh

* remove modifier

* working version of extended benefits

* finish company section

* feat(company-section): add alt tags for company logos

* style(global.scss): code review changes

* 40 rework swoosh (#41)

* fix: remove old swoosh

re #40

* fix: remove swoosh from css

re #40

* fix: add new swoosh

fixes #40

* refactor(swoosh): remove old swoosh css

* refactor(swoosh): remove alternative implementation of new swoosh

* style(swoosh): change order of css attributes

* refactor(swoosh): update variables + variable usage

* feat(global-style): adjusted some stylings (splash bg, positioning)

* feat(buttons): add button with orange gradient

* fix(buttons): make outline of button white

* 15 implement scroll animated section (#33)

* BioScrollAnimation:
- implented component for scroll enabled animation using scrollMagic with gsap and bodymovin
- add missing files
- refactored function names of BioScrollAnimation.ts
- use const where appropriate
- markup: changed section id to class name
- updated BioScrollAnimation to be consistent with newer components created with biotope generate 2.0.0

- reduced number of option props in interface
- added animation.json from Joachim Roschka
- removed demo animation data
- use Lottie instead of bodymovin to load and render animation
- load animation via path with lottie instead of javascript fetch
- disable scroll indicators of ScrollMagic
- fixed responsive sizing of svg animation
- added SEO text to bio-scroll-animation section
- cleanup

* #23 button component (#44)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* button sizing adjustments

* added url param to buttons

* grid improvements for footer

* 17 resources section (#43)

* created BioRsource component started mobile implementation

* finish resources section for desktop and tablet. button adjustments required from button branch

* padding adjustments to make content visible

* resources layout cleanup

* PR changes and small cleaning in styles

* #1 splash screen section header (#48)

* desktop slpash adjustments

* removing comments

* 15 implement scroll animated section (#45)

* biotope website:
- implented component for scroll enabled animation using scrollMagic with gsap and bodymovin

* biotope website:
- add missing files

* workflow testing

* workflow testing

* remove workflow

* biotope website:
- refactored function names of BioScrollAnimation.ts
- use const where appropriate
- markup: changed section id to class name

* biotope website:
- updated BioScrollAnimation to be consistent with newer components created with biotope generate 2.0.0

* biotope website, BioScrollAnimation:
- reduced number of option props in interface
- added animation.json from Joachim Roschka
- removed demo animation data
- use Lottie instead of bodymovin to load and render animation
- load animation via path with lottie instead of javascript fetch
- disable scroll indicators of ScrollMagic
- fixed responsive sizing of svg animation
- added SEO text to bio-scroll-animation section

* biotope website, BioScrollAnimation: cleanup

* biotope website, BioScrollAnimation:
- implemented automatic "snap to slides" instead of a linear scroll animation.
- updated animation data from Jogi (but still not final! issue: animation slides are not of equal duration)
- updated SEO text in scaffolding

* biotope website, BioScrollAnimation:
- updated animation data from Jogi (but still not final! issue: animation slides are not of equal duration)

* biotope website, BioScrollAnimation:
- added dynamic ans interactive slide controls
- new markup and data structure for slides
- generic creation of slides data structure based on sections in markup
- removed obsolete props and attributes
- dispatch custom event 'bioScrollAnimation.showSlide', required for tracking
- fixed width of animation-wrapper

* biotope website, BioScrollAnimation:
- made code for getting title of slide more robust
- remeoved obsolete comment

* fix(biobutton): fix button triggering a redirect when it doesn't have a URL

* created soEasySection (#47)

* created soEasySection

* text adjustments and spacing improvements

* header adjustment

* cleaning

* 15 implement scroll animated section (#51)

- fixed automatic scrolling issues after window resize
- fixed animation-container width to correctly resize to the window's with

* reaplied soEasy section back in

* #23 button component (#53)

* added button functionality to buttons with # and buttons with links

* updated latest animation data and text (#55)

optimized position of slide controls

* implemented "Want to know more" section (#54)

* implemented "Whant to know more" section with call to action button with mailto link

* removed obsolete scss import

* fixed typo

* 9 tracking (#50)

* adding tracking

* adjusted naming, meged develop

* improved tracking script

* removed unecessary package @types/google.analytics

* adapting extended benefits sizing (#56)

* #23 button component (#57)

* initial state of buttons ready #23ButtonComponent

* added more colors to _settings for button gradients, changed colors to variables, added a hover effect, changed buttons to a tags

* consistency update for namings

* consistency update #2

* rewritten butons to use bio elements

* renaming

* another moddifier added purpleFull

* changed buttons to solid colors

* cleaning

* cursor change

* button sizing adjustments

* added url param to buttons

* added button functionality to buttons with # and buttons with links

* cleaning

* PR changes

* improving button styling

* fixed javascript error this.props.url is undefined or null

* 42 whos behind biotope (#49)

* feat(biomodal): implement first steps of bioModal

re #42

* feat(biomodal): fully implement modal

* feat(whosbehind): adjustments to modal, implement bioCollaboratorList

re #42

* chore: merge develop branch

clean out merge conflicts

* improved css like Ivaylo suggested

* feat(compatibility): add IE11 polyfills

* refactor: remove unused components and delete bioHeadline

bioHeadline is unnecessarily complicated for something that we can do with native html elements.

* github corner color fix

* removing free icon, applying new 100% open source icon and adding text for benefits section

* 16 so easy section (#61)

* created soEasySection

* text adjustments and spacing improvements

* 9 tracking (#58)

* adding tracking

* adjusted naming, meged develop

* improved tracking script

* removed unecessary package @types/google.analytics

* Implement tracking: internal/external links, mailto links and modal links

* 18 extended benefits (#62)

Text Changes and icons

* 42 whos behind biotope - IMPLEMENT DESIGN (#59)

* feat(biomodal): implement first steps of bioModal

re #42

* feat(biomodal): fully implement modal

* feat(whosbehind): adjustments to modal, implement bioCollaboratorList

re #42

* chore: merge develop branch

clean out merge conflicts

* improved css like Ivaylo suggested

* feat(whosbehind): implement design, remove tab implmentation

re #42

* refactor(biomodal): remove references to delete component

* fix(biomodal): add bioCollaboratorTile to bioModal dependencies

* minor changes

* splash header section changes and optimization for IE1 (#60)

* splash header section changes and optimization for IE1

* changed button link position

* 17 resources section (#63)

* created BioRsource component started mobile implementation

* finish resources section for desktop and tablet. button adjustments required from button branch

* padding adjustments to make content visible

* resources layout cleanup

* PR changes and small cleaning in styles

* design QA up till resource section

* Design QA final feedback to be applied

* 40 rework swoosh (#64)

* Implement new swoosh component

* add new swoosh component to footer
fix position and padding of sections for swoosh

* fixed scss variable name

* 9 tracking update (#66)

- implemented scroll tracking
- modified main sections for tracking: added ids and updated ids and classNames (for consistency)
- link tracking: track href instead of link text or title

* paragraph color readjustings, General stying, Removing of paragraph component

* center sections adjust claim intro, adjust font for splash claim

* 67 seo use h3 headlines instead of biosectionheadline component (#68)

 SEO fix: use proper h1- h4 headline structure
optimized headline styles

* refactor easy setup component structure

* spelling corrections

* spelling changes v2

* move animation.json to _assets

* modal: optimized position of close button

* bio-swoosh: fixed IE11 and Edge SVG rendering issues

* chore(polyfills): remove duplicate script tags

There were script tags to get polyfills that were already implemented somewhere else before.

* 70 ie11grid fix (#78)

* fixed inverted color text for bio-benefits, fixed grid sizing for StartBuildingWithinMinutes

* fix for bio-benefits image height on safari

* screen overlaping fix for splash screen

*  smooth scrollig effect on buttons (#103)

* 80 update collab list (#100)

* feat(bio-collaborators): add collaborators to list

* feat(bio-collaborators): add collaborators to list

* refactor(collaborators): code review clean up

* feat(biocollaborators): add missing github links

* feat(biocollaborator): add iamge for tiago, change hover pointer

* 71 cookiebanner (#97)

* feat(cookiebanner): add cookiebanner

re #71

* feat(cookiebanner): change text

* feat(cookiebanner): finish cookiebanner functionality

initialize GTM & GA only after user pressed accept, remove cookies when user presses decline etc

re #71 re #96

* fix(biocookiebanner): fix mobile styles

* refactor(biocookiebanner): remove test id

* feat(biocookiebanner): make buttons white (#111)

* cookie banner readability improvement, mobile adjustments

* text readability <br> change

* text changes - Biotope consistency, Favicon, title, Description, link adjustments, removed knowMore section (#101)

* feat(fonts): remove google fonts link, self-host fonts (#110)

#108

* Privacy policy added, link styling applied (#112)

* fixed safari bloated code examples and made adjustments for chrome accordingly (#113)

* nesting fix for bloated fix

* spelling misstakes taken care of

* using a timeout prevents iOS Safari from executing scroll handler before accelerated scrolling really is finished (#114)

* cleaning, cookie banner decline options, spelling misstakes

* cleaning, text changes for privacy policy, cookie banner text

* 81 update animation seo text (#115)

* update animation and SEO text.

* dynamically set aspectRatio handling, still needs improvement.

* removed dynamically aspectRatio handling, updated animation data instead.

* cleanup and small iOS fix for swoosh

* svg sizing for good company logos

* collaborators: set missing height of github profile images (#118)

* added 24 months as LinkedIn campaign time instead of ?

* : to . change

* text changes and adjustments

* 127 privacy policy link in cookie banner (#128)

* refactor part of cookie banner to accept slotted P text so that we can use a link to PrivacyPolicy

* cleaning

* cleaning

* Updated the animation.json and the texts in the corresponding component. (#130)

* 131 improve set up sec (#137)

* installation section adjustments

* mobile cookie banner adjustments (#136)

* mobile cookie banner adjustments

* swoosh: improved margin feature (#138)

* Biowebsite ci cd (#139)

* Create biowebsiteCICD.yml
* initial biotope website cd workflow

* resources section set URL of read docs button (#144)

set the URL of the second read docs button in the resources section to the same URL as the one in the splash screen section:

https://github.com/biotope/biotope/blob/master/docs/quickstart.md

* feat(tracking): add tracking for github links (#148)

* fix(company-logos): fix size/distortion of company logos (#149)

fix #147

* collaborator modal: fixed z-index and github links clickable area (#143)

* changing favicon sizing to 1024 (#156)

* changing favicon sizing to 1024

* fix(favicons): fix favicons path

#140

* fix(favicons): fix favicons path

forgot an 's'

#140

* Changing the contact buttons to links (#155)

* prevent scroll and resize issues on Android and iOS (#157)

* cookie banner: change LinkedIn expiration date to 12

* Simplyfy scrolling (#160)

simplify scrollAnimation component: remove scroll hijacking

* feat(tracking): rework tracking optout (#161)

* feat(tracking): rework tracking optout

before: tracking optout via re-opening of cookiebar -> decline.; now: google optout by clicking a
link that updates a label. linkedin optout with an external link.

* cookie consent: refactor to ES5 compatible indexOf

* fix(tracking): add hostname to delete cookie function (#163)

* fix(spelling): fix spelling "future-proof" (#171)

fix #167

* feat(biocollaborators): move danny to collaborators (#172)

#169

* 166 native elements (#174)

* removing unnecessary functionality from buton, applying it to the link

* correcting resource loader for linkButtons

* feat(seo): add opengraph image (#170)

* feat(seo): add opengraph image

fixes #165

* changing og image to png

* testing with url instead of image dir

* testing with a bigger og image

* changing the image to detect secure paths

* trying to use http without secure

* changing size for image

* trying images that work

* cleaning

* poking in the dark og image

* feat(bioeasysetup): add code copy feature (#173)

* feat(bioeasysetup): add code copy feature

Added a little hover-button that lets the user copy the code snippets in the Easy Setup section.

re #168

* removing functionality for mobile because of text overlaping

* changed mailto link (#179)

* 176-button tracking fixed, removed deprecated url attribute on buttons (#178)

* fixed scaffolding files for BioButton (removed url attribute) and BioLinkButton (renamed url attribute to href)

(cherry picked from commit 239d41e)

* fixed tracking for internal links by using a regex to identify hostnames that end on "biotope.sh" or are "localhost" to identify all links correctly

(cherry picked from commit 43c5b75)

* added missing classes "white" and "compact" to the BioButton styles to show the correct styling (white border, white text color, smaller width on smaller devices) in the cookie banner. Removed not used "compact" class from BioLinkButton because these have a fixed width of 160px and therefore the min-width in the compact class did not have any effect.

* added a canonical tag by setting a corresponding variable in the page file. This is sensible because the canonical tag should be set for each page individually to avoid issues with SEO once we add more pages.

* minor changes

* fix: Downgrade handlebars from 4.3.0 to 4.1.2

Fix page build

Co-authored-by: Lukas Müller <lukas.mueller@virtual-identity.com>
Co-authored-by: clemens-vi <59684329+clemens-vi@users.noreply.github.com>
Co-authored-by: clemensf <clemens.fiedler@posteo.de>
Co-authored-by: Ralf Hafner <ralfhafner@gmail.com>
Co-authored-by: Kai Wißler <kai.wissler@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant