fall back to rage if age is unavailable #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcxio
force-pushed
the
rage
branch
2 times, most recently
from
b90efc5
to
404255d
Compare
biox
approved these changes
Jun 23, 2024
|
lgtm! i don't see why we shouldn't fall back to rage, especially given that rage aims to be interoperable with age. if rage ever changes this stance, maybe we reconsider! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested pa with rage and it does indeed work without issues just by changing the binary name, so maybe there's no reason to limit the options. I'd leave it as an undocumented option though, age would still be recommended as a reference implementation with a more active development (and it's still faster AFAIU - str4d/rage#57). Passage provides
PASSAGE_AGEoption to change the binary name, but I think that solution is worse: in addition to being a redundant configuration option that can just be inferred from what's installed, age spec doesn't specify API for CLIs, so there's no guarantee that any CLI that's going to implement age protocol is going to be interoperable in terms of interface with age(1) the way rage is.