Skip to content

Commit

Permalink
fix: drop bogus { type: 'module' } from Worker instantiation
Browse files Browse the repository at this point in the history
This was causing Firefox beta 111 to break since it starts parsing this
annotation and then failing when it is set.

Fixes #1080.
  • Loading branch information
birtles committed Feb 23, 2023
1 parent c402ff8 commit d8b02c7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ app.
- (Chrome, Edge) Migrated to Manifest version 3.
- (Safari) Fixed a bug where the toolbar icon would get stuck not updating.

## [1.13.6] - TBD (Firefox, Thunderbird only)

- Fixed breakage on Firefox beta
([#1080](https://github.com/birchill/10ten-ja-reader/issues/1080)).

## [1.13.5] - 2022-12-02

- Added support for parsing ざるを得ない endings, e.g. 闘わざるをえなかった.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<div align="center">
<img src="images/10ten-ja-reader.svg" alt="10ten Japanese Reader" width="200" height="200" />
<h1>10ten Japanese Reader</h1>

<p>
Hi fellow Japanese reader! Formerly known as Rikaichamp, this browser extension lets you look up Japanese words with the hover of a mouse or tap of a screen.
</p>

<p>
<a href="https://twitter.com/10tenstudy"><img src="https://img.shields.io/twitter/follow/10tenstudy" alt="Follow @10tenstudy"></a>
<a href=""><img src="https://github.com/birchill/10ten-ja-reader/workflows/Automated%20tests/badge.svg" alt="automated test status" /></a>
Expand Down
2 changes: 1 addition & 1 deletion src/worker/jpdict-worker-backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export class JpdictWorkerBackend implements JpdictBackend {
private listeners: Array<JpdictListener> = [];

constructor() {
this.worker = new Worker('./10ten-ja-jpdict.js', { type: 'module' });
this.worker = new Worker('./10ten-ja-jpdict.js');
this.worker.onmessageerror = (event: MessageEvent) => {
console.error(`Worker error: ${JSON.stringify(event)}`);
void Bugsnag.notify(`Worker error: ${JSON.stringify(event)}`);
Expand Down

0 comments on commit d8b02c7

Please sign in to comment.