Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Mouse Hover Support #1009

Closed
ghost opened this issue Nov 9, 2022 · 7 comments · Fixed by #1016
Closed

[Feature Request] Mouse Hover Support #1009

ghost opened this issue Nov 9, 2022 · 7 comments · Fixed by #1016

Comments

@ghost
Copy link

ghost commented Nov 9, 2022

I've been using this extension for a while on Safari for iOS,and it's great! However, some of the sites I use have Japanese text that appears only on mouse hover. As of now I can manage to get the hovered text to show up a moment, then when I move the puck, the hovered text goes away. Would it be possible to implement the ability to make the puck send a mouse hover to the web page wherever the puck is pointing? Thanks!

@birtles
Copy link
Member

birtles commented Nov 19, 2022

Hi @trd-db! Thank you very much for your feedback and for using 10ten on Safari for iOS! Sorry for my delay in getting back to you.

At the moment, the puck should already be sending a mouse hover to the web page (source reference) so I'm not sure why it's not working.

Can you tell me which Web page it's not working on?

@ghost
Copy link
Author

ghost commented Nov 19, 2022

I'm specifically referring to mokuro, a program which generates html files for manga with OCR'd text. On hover, the text shows up, but the 10ten puck isn't making the text box show up.

The repo has a example page hosted: https://github.com/kha-white/mokuro

@birtles
Copy link
Member

birtles commented Nov 19, 2022

Thank you! I see, I can reproduce that issue now.

It appears to be because that page uses CSS :hover styles to show the text elements. However, the synthetic (untrusted) events generated by the puck will not trigger :hover styles (SO reference).

Perhaps we can add a specific handling for mokuro to peek into the hidden text elements.

@ghost
Copy link
Author

ghost commented Nov 26, 2022

That would work, if there was a good way for it to detect it was on a mokuro page, as long as the look ups were made possible on mobile.

@birtles
Copy link
Member

birtles commented Dec 1, 2022

First attempt was somewhat successful, but only when the OCR'ed text happens to line up quite closely with the original text:

Untitled.Project.mp4

I'm going to try again, this time making the text boxes actually show up.

@birtles
Copy link
Member

birtles commented Dec 1, 2022

Looking at bit better

Untitled.Project.2.mp4

@birtles
Copy link
Member

birtles commented Dec 1, 2022

On iPhone

RPReplay_Final1669886095.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant