🐛 [BUG]: Silent error when EXTRA_CONF_DIRS is invalid #266
Assignees
Labels
bug
Something isn't working
Comments
|
Thanks for submitting an issue. |
|
We do not validate those dirs because all the files (docker-compose-extra.yml, default.env) under those dirs are optional, but probably we need to validate the dir itself, without validating the files under. |
tlvu
added a commit
that referenced
this issue
Dec 23, 2022
…ot take effect and warn when a dir in `EXTRA_CONF_DIRS` does not exist (#272) ## Fixes: - Overriding `DATA_PERSIST_ROOT` in `env.local` do not take effect for `JUPYTERHUB_USER_DATA_DIR`, `MAGPIE_PERSIST_DIR`, and `GEOSERVER_DATA_DIR`. These 3 vars will have to be delayed evaluated for override in `env.local` to take effect. For a variable to be delayed evaluated, it has to be defined using single-quote and be added to the list of `DELAYED_EVAL` in `default.env`. If those steps are forgotten in `env.local`, it will still work since `env.local` is the last file to be read. However those steps should not be forgotten in any `default.env` for all components. So the impact or burden is on the developpers to write their `default.env` file properly, not on the users that only modify the `env.local` file. All `default.env` files header have been updated with notice about this new delayed evaluation feature. Fixes #270 ## Changes: - Warn when a dir in `EXTRA_CONF_DIRS` does not exist. Most likely a typo in a new dir. Just warn and not exit directly to avoid leaving the entire platform down during an unattended autodeploy since no one is around to take immediate action. Fixes #266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When adding a directory to EXTRA_CONF_DIRS, if there is a typo in its name, the error goes unnoticed.
Feel free to close this if not important enough, but I felt that it would be nice if
pavics-compose.shwould fail when encountering an invalid directory name.The text was updated successfully, but these errors were encountered: