Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature] Add license #309

Closed
huard opened this issue Apr 6, 2023 · 5 comments · Fixed by #316
Closed

💡 [Feature] Add license #309

huard opened this issue Apr 6, 2023 · 5 comments · Fixed by #316
Assignees
Labels
enhancement New feature or request

Comments

@huard
Copy link
Collaborator

huard commented Apr 6, 2023

Description

The license should be specified.

References

Concerned Organizations

@huard huard added the enhancement New feature or request label Apr 6, 2023
@tlvu
Copy link
Collaborator

tlvu commented Apr 13, 2023

@Zeitsperre Sorry, forgot again, we prefer MIT or Apache licence again? I think it's Apache but I rather confirm with you again.

@tlvu
Copy link
Collaborator

tlvu commented Apr 13, 2023

Looks like we already answered this question here #140 (comment)

@tlvu tlvu mentioned this issue Apr 13, 2023
tlvu added a commit that referenced this issue Apr 13, 2023
@Zeitsperre
Copy link
Contributor

Zeitsperre commented Apr 13, 2023

@tlvu We need to add the boilerplate to the __init__.py at least, right?

   Copyright 20XX-20YY Bird-house and Contributors

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.

@tlvu
Copy link
Collaborator

tlvu commented Apr 14, 2023

We need to add the boilerplate to the __init__.py at least, right?

@Zeitsperre birdhouse-deploy is not a python project, it has no __init__.py. I added a full blown LICENCE file at the root of the repo. The file generated by Github. See commit ee3dd45

@Zeitsperre
Copy link
Contributor

Right. My error!

@tlvu tlvu closed this as completed in #316 Apr 17, 2023
tlvu added a commit that referenced this issue Apr 17, 2023
  * Update list of OS tested
  * Framework tests code block not rendering properly
  * Fixes #312
  * Fixes #309
  * Fixes #57
  * Fixes #53
  * Fixes #55
  * Fixes #52
* Update the "Release Instructions" in the README to use `make bump
<major|minor|patch>` command instead of directly calling `bump2version`
to harmonize with the section "Tagging policy" right above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants