Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ncWMS2 by THREDDS WMS service #9

Closed
tlvu opened this issue Jan 29, 2020 · 6 comments · Fixed by #311
Closed

Replace ncWMS2 by THREDDS WMS service #9

tlvu opened this issue Jan 29, 2020 · 6 comments · Fixed by #311

Comments

@tlvu
Copy link
Collaborator

tlvu commented Jan 29, 2020

Migrated from old PAVICS https://github.com/Ouranosinc/PAVICS/issues/167, had lots of discussion, summarize below.

Find where in the platform links to the ncWMS2 are used and replaced them with links to the THREDDS WMS service.

Related to https://github.com/Ouranosinc/PAVICS/issues/108

Need more testing to be confident Thredds WMS can replace ncwms2 both in terms of integration with the rest of the components and performance before we pull the plug on ncwms2.

@huard
Copy link
Collaborator

huard commented Feb 6, 2023

@tlvu This is done, correct ?

@tlvu
Copy link
Collaborator Author

tlvu commented Feb 6, 2023

If my memory is correct, we have activagted WMS service on Thredds but we still keep the old ncWMS2 service running while we slowly convert all the tutorial noteoboks to use the new WMS from Thredds?

Let me find the PR that activated WMS on Thredds, maybe there is a note left behind.

@huard
Copy link
Collaborator

huard commented Feb 6, 2023

I think the only notebook using WMS is already hitting thredds for WMS: https://pavics-sdi.readthedocs.io/en/latest/notebooks/rendering.html#Gridded-Data-Renderer

@tlvu
Copy link
Collaborator Author

tlvu commented Feb 6, 2023

I finally traced the PR that activated WMS, it was in the old PAVICS repo: https://github.com/Ouranosinc/PAVICS/pull/161 no mention about what to do next with the duplicate ncWMS.

Have we observed any integration and performance difference with ncWMS? If not I guess we can pull the plug on ncWMS.

@huard
Copy link
Collaborator

huard commented Feb 6, 2023

I think THREDDS uses ncwms internally ; ) Unidata/thredds#234 so it should be pretty much the same.

@tlvu
Copy link
Collaborator Author

tlvu commented Jun 14, 2023

Should be fixed by #311

@tlvu tlvu closed this as completed Jun 14, 2023
mishaschwartz added a commit that referenced this issue Jul 6, 2023
## Overview

Move unused and unmaintained components to a separate
`deprecated-components/` subdirectory and remove
them from the DEFAULT_CONF_DIRS list if required.

## Changes

**Non-breaking changes**

**Breaking changes**
- The following components are no longer present by default:
  - catalog
  - frontend
  - malleefowl
  - ncops
  - ncwms2
  - project-api
  - solr
  - phoenix

## Related Issue / Discussion

- Resolves #214
- Closes #287 
- Resolves #206
- Closes #291 
- Resolves #9
- Closes #292 
- Resolves #290 

## Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment