Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributions guideline and policy #156

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Conversation

dbyrns
Copy link
Collaborator

@dbyrns dbyrns commented Apr 27, 2021

Overview

  • Adds contributions guideline and policy as discussed
  • Adds a pull request template

.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@matprov matprov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes but looks good overall

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, thanks for the PR.

.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another minor thing I noticed.

.github/CONTRIBUTNG.md Outdated Show resolved Hide resolved
@tlvu
Copy link
Collaborator

tlvu commented Apr 28, 2021

@nikola-rados FYI, might impact PCIC.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@dbyrns dbyrns merged commit 02d1e9d into master Apr 28, 2021
@dbyrns dbyrns deleted the contributions-guideline branch April 28, 2021 21:13
This was referenced Apr 29, 2021
@tlvu
Copy link
Collaborator

tlvu commented May 5, 2021

Oh check this out guys https://github.blog/2021-04-27-ship-code-faster-safer-feature-flags/

I proposed the term "Feature toogle" and github used "Feature flags" ! Both are to achieve the exact same goals !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants