add gitignore for build dir of docs #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlvu
approved these changes
May 4, 2021
There was a problem hiding this comment.
I am confused. This same gitignore will be available once the "3.4 PR" #152 is merged.
I thought you are willing to wait for that "3.4 PR" in PR #153 already.
But if you split this gitignore out so it can be merged immediately, I have no objection. I even tried to convince you to do the samething for #153 so it can be merged without waiting for the "3.4 PR".
|
This one is easy so can be added separately, as it won't be in the repo until #152 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add gitignore for build dir of docs
Changes
Non-breaking changes