Deprecated unused/unmaintained components #311
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,10 @@ | ||
| # Old paths. Keep these so that old config files remain uncommittable after updates. | ||
| postgres-magpie/ | ||
| catalog/ | ||
| frontend/ | ||
| malleefowl/ | ||
| ncops/ | ||
| ncwms2/ | ||
| project-api/ | ||
| solr/ | ||
| phoenix/ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| magpie: | ||
| volumes: | ||
| - ./config/thredds/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/thredds-providers.cfg:ro |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| providers: | ||
| thredds: | ||
| url: http://thredds:8080/twitcher/ows/proxy/thredds | ||
|
There was a problem hiding this comment. Same as per other comment. There was a problem hiding this comment. |
||
| title: Thredds | ||
| public: true | ||
| c4i: false | ||
| type: thredds | ||
| sync_type: thredds | ||
| # below is a custom config to indicate how magpie should convert thredds path elements into resources/permissions | ||
| # see: https://pavics-magpie.readthedocs.io/en/latest/services.html#servicethredds | ||
| configuration: | ||
| skip_prefix: "thredds" # prefix to ignore, below prefixes will be matched against whatever comes after in path | ||
| file_patterns: | ||
| # note: make sure to employ quotes and double escapes to avoid parsing YAML error | ||
| - ".+\\.ncml" # match longest extension first to avoid tuncating it by match of sorter '.nc' | ||
| - ".+\\.nc" | ||
| metadata_type: | ||
| prefixes: | ||
| - null # note: special YAML value evaluated as `no-prefix`, use quotes if literal value is needed | ||
| - "\\w+\\.gif" # threddsIcon, folder icon, etc. | ||
| - "\\w+\\.ico" # favicon | ||
| - "\\w+\\.txt" # licence | ||
| - "\\w+\\.css" # tds.css | ||
| - "catalog\\.\\w+" # note: special case for `THREDDS` top-level directory (root) accessed for `BROWSE` | ||
| - catalog | ||
| - ncml | ||
| - uddc | ||
| - iso | ||
| data_type: | ||
| prefixes: | ||
| - fileServer | ||
| - dodsC | ||
| - wcs | ||
| - wms | ||
| - ncss | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| Deprecated Components | ||
| ##################### | ||
|
|
||
| .. contents:: | ||
|
|
||
| All components in this directory are not actively maintained. | ||
mishaschwartz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| If you wish to include these components in the deployed stack, additional work | ||
| may be required to make them compatible with the current stack. | ||
|
|
||
| Components in this directory may be removed from this repository at any time. | ||
|
|
||
| This directory also contains additional configurations for these deprecated components in: | ||
|
|
||
| - `all-public-access-deprecated/` | ||
| - `canarie-api-full-monitoring-deprecated/` | ||
| - `wps-healthchecks-deprecated/` | ||
|
Comment on lines
+13
to
+17
There was a problem hiding this comment. Thinking about this again... Is there actually any reason to move them under a separate configuration? If I activated for example: EXTRA_CONF_DIRS="
./components/weaver
./deprecated-components/malleefowl
./optional-components/all-public-access-deprecated
./optional-components/canarie-api-full-monitoring
./optional-components/wps-healthchecks
"Wouldn't the following be loaded (not necessarily exhaustive or in the right order below)? ./components/weaver/*
./deprecated-components/malleefowl
./optional-components/all-public-access-deprecated/mallefowl/*
./optional-components/all-public-access-deprecated/weaver/*
./optional-components/canarie-api-full-monitoring/mallefowl/*
./optional-components/canarie-api-full-monitoring/weaver/*
./optional-components/wps-healthchecks/mallefowl/*
./optional-components/wps-healthchecks/weaver/*In order words, whether the main services are under I find this would be easier to maintain because a service moving between There was a problem hiding this comment.
At the moment yes but that is a mistake. I just forgot to delete the catalog and malleefowl directories under optional-components/wps-healthchecks/ I've remove them now.
I think that you need to think about whether you actually want to deprecate these components or not. In my opinion, the point of moving them into a separate folder is to clearly mark that they are deprecated and no longer maintained. Developers then can focus on maintaining the other components without worrying about breaking components that we don't care about anymore. The only reason I can think of to keep supporting code in the optional-components folder is if you think that these components will be "un-deprecated" at some point. There was a problem hiding this comment. If someone needs to work on, for example, There was a problem hiding this comment. Up to you... I moved them back |
||
|
|
||
| These contain the settings to extend the deprecated components that have been moved from the corresponding | ||
| directories under `birdhouse/optional-components`. | ||
|
|
||
| To enable these additional configurations; add them to the `EXTRA_CONF_DIRS` variable (in `env.local`) | ||
| as you would to enable any component. For example, to enable the deprecated malleefowl component as well as the | ||
| wps-healthchecks for malleefowl. The `EXTRA_CONF_DIRS` variable should contain: | ||
|
|
||
| .. code-block:: shell | ||
|
|
||
| ./deprecated-components/malleefowl | ||
| ./wps-healthchecks-deprecated | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/catalog/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/catalog_canarie_api_monitoring.py:ro |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| version: "3.4" | ||
| services: | ||
| magpie: | ||
| volumes: | ||
| - ./deprecated-components/catalog/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/catalog-providers.cfg:ro | ||
| - ./deprecated-components/catalog/config/magpie/permissions.cfg:${MAGPIE_PERMISSIONS_CONFIG_PATH}/catalog-permissions.cfg:ro |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/frontend/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/frontend_canarie_api_monitoring.py:ro |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/frontend/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/frontend:ro |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/malleefowl/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/malleefowl_canarie_api_monitoring.py:ro |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| magpie: | ||
| volumes: | ||
| - ./deprecated-components/malleefowl/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/malleefowl-providers.cfg:ro |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| magpie: | ||
| volumes: | ||
| - ./deprecated-components/ncwms2/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/ncwms2-providers.cfg:ro |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/ncwms2/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/ncwms2:ro |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/phoenix/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/phoenix_canarie_api_monitoring.py:ro |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/project-api/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/project-api_canarie_api_monitoring.py:ro |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/project-api/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/project-api:ro |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "3.4" | ||
| services: | ||
| proxy: | ||
| volumes: | ||
| - ./deprecated-components/solr/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/solr_canarie_api_monitoring.py:ro |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| # Old paths. Keep these so that old config files remain uncommittable after updates. | ||
| canarie_api_full_monitoring.py | ||
| config/proxy/canarie_api_full_monitoring.py | ||
| config/canarie-api/canarie_api_full_monitoring.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Old paths. Keep these so that old config files remain uncommittable after updates. | ||
| canarie_api_full_monitoring.py |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for remembering this to not break autodeploy !