Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "all-public-access" optional component for automated integration testing #92

Merged
merged 12 commits into from Nov 4, 2020

Conversation

matprov
Copy link
Collaborator

@matprov matprov commented Nov 3, 2020

When enabled, allows authtest user and anonymous group to access all wps endpoints and thredds.

Note that the authtest user needs to be created with the create-magpie-user script.

@matprov matprov requested a review from tlvu November 3, 2020 21:04
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes requested.

Please also add something to the https://github.com/bird-house/birdhouse-deploy/blob/master/birdhouse/optional-components/README.md mentioning this component will open up public access to all services listed in birdhouse/config/magpie/providers.cfg.template, user beware when enable this, that this is useful for the test suite in https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests. Follow existing format description of other optional-components.

The .gitignore file is empty, please remove it.

@tlvu tlvu changed the title Add "all-public-access" optional component Add "all-public-access" optional component for automated integration testing Nov 3, 2020
@tlvu
Copy link
Collaborator

tlvu commented Nov 3, 2020

@matprov will work in another PR, I'll include the bootstrap-testdata script you've used, a trigger-crawler script, sample config to create that authtest user and update the README to mentions "steps" to make the new instance "test ready". Anything I forgot to get the fresh instance ready for our Jenkins test suite?

@matprov
Copy link
Collaborator Author

matprov commented Nov 3, 2020

@matprov will work in another PR, I'll include the bootstrap-testdata script you've used, a trigger-crawler script, sample config to create that authtest user and update the README to mentions "steps" to make the new instance "test ready". Anything I forgot to get the fresh instance ready for our Jenkins test suite?

Since I've removed rights for anonymous data access, notebooks accessing data anonymously would then need to be fixed.

Other than that changes you propose seems fine to me.

@matprov matprov requested a review from tlvu November 4, 2020 01:40
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, minor changes requested. By the way, lost the http(S) on the link to http://daccs-jenkins.crim.ca again, did you forget to commit jenkins config change to jenkins?

birdhouse/optional-components/README.md Outdated Show resolved Hide resolved
birdhouse/optional-components/README.md Outdated Show resolved Hide resolved
birdhouse/optional-components/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@matprov
Copy link
Collaborator Author

matprov commented Nov 4, 2020

By the way, lost the http(S) on the link to http://daccs-jenkins.crim.ca again, did you forget to commit jenkins config change to jenkins?

I've simply put this aside for the moment, was not a priority as for the tests that need to pass.
We will address this later on.

@matprov matprov merged commit 5c760bd into master Nov 4, 2020
@tlvu tlvu deleted the all-public-access branch November 4, 2020 02:50
tlvu added a commit that referenced this pull request Nov 6, 2020
…mated-tests

Prepare fresh deployment for automated tests.

@matprov is building an automated pipeline that will provision and deploy a full PAVICS stack and run our Jenkins test suite for each PR here.

So each time his new fresh instance comes up, there are a few steps to perform for the Jenkins test suite to pass.  Those steps are captured in `scripts/bootstrap-instance-for-testsuite`.  @matprov please call this script, do not perform each steps yourself so any future changes to those steps will be transparent to your pipeline.  A new optional components was also required, done in PR #92.

For security reasons, Jupyterhub will block the test user to login since its password is known publicly.

Each step are also in their own script so can be assembled differently to prepare the fresh instance if desired.

Solr query in the canarie monitoring also updated to target the minimal dataset from `bootstrap-testdata` so the canarie monitoring page works on all PAVICS deployment (fixes #6).  @matprov you can use this canarie monitoring page (ex: https://pavics.ouranos.ca/canarie/node/service/status) to confirm the fresh instance is ready to run the Jenkins test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants