-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-add OUTPUT_URL #349
re-add OUTPUT_URL #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested this so approve of course :D
Can you try the make refresh-notebook
target and see if the output URL is proper now?
I needed to yank birdhouse-birdy v0.8.5 since the PyPI package was not appropriately marked as incompatible with Python3.8. v0.8.6 has been there since last week. |
## Overview Changes: * Fixed the license file so that it can be parsed by GitHub properly * Updated a few development dependencies ## Related Issue / Discussion ## Additional Information Links to other issues or sources.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
So birdhouse-birdy 0.8.5 and 0.8.6 are identical, except for metadata update for 0.8.6? If I have a Jupyter env built with 0.8.5 already, I do not need to update to 0.8.6? 0.8.6 is simply to prevent installation on py38? |
@tlvu Exactly. The yanked version is to prevent broken installations on Python3.8 only. There were quite a few changes to the packaging/boilerplate with v0.8.6. In all honesty, it should have been a major version bump, but it's fine. The core logic is entirely untouched (except for changes to drop Python3.8 introduced in v0.8.5). |
Overview
This PR fixes https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/1
Changes:
OUTPUT_URL
to the Makefile configurationRelated Issue / Discussion
Additional Information
Links to other issues or sources.