Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add OUTPUT_URL #349

Merged
merged 7 commits into from
Mar 19, 2024
Merged

re-add OUTPUT_URL #349

merged 7 commits into from
Mar 19, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 19, 2024

Overview

This PR fixes https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/1

Changes:

  • Re-adds the OUTPUT_URL to the Makefile configuration

Related Issue / Discussion

Additional Information

Links to other issues or sources.

@Zeitsperre Zeitsperre requested a review from tlvu March 19, 2024 16:51
@Zeitsperre Zeitsperre self-assigned this Mar 19, 2024
@github-actions github-actions bot added the CI Continuous Integration label Mar 19, 2024
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested this so approve of course :D

Can you try the make refresh-notebook target and see if the output URL is proper now?

@Zeitsperre
Copy link
Collaborator Author

I needed to yank birdhouse-birdy v0.8.5 since the PyPI package was not appropriately marked as incompatible with Python3.8. v0.8.6 has been there since last week.

## Overview

Changes:

* Fixed the license file so that it can be parsed by GitHub properly
* Updated a few development dependencies

## Related Issue / Discussion

## Additional Information

Links to other issues or sources.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Mar 19, 2024
@tlvu
Copy link
Collaborator

tlvu commented Mar 19, 2024

I needed to yank birdhouse-birdy v0.8.5 since the PyPI package was not appropriately marked as incompatible with Python3.8. v0.8.6 has been there since last week.

So birdhouse-birdy 0.8.5 and 0.8.6 are identical, except for metadata update for 0.8.6? If I have a Jupyter env built with 0.8.5 already, I do not need to update to 0.8.6? 0.8.6 is simply to prevent installation on py38?

@Zeitsperre
Copy link
Collaborator Author

Zeitsperre commented Mar 19, 2024

@tlvu Exactly. The yanked version is to prevent broken installations on Python3.8 only.

There were quite a few changes to the packaging/boilerplate with v0.8.6. In all honesty, it should have been a major version bump, but it's fine. The core logic is entirely untouched (except for changes to drop Python3.8 introduced in v0.8.5).

@Zeitsperre Zeitsperre merged commit a223b7c into master Mar 19, 2024
9 checks passed
@Zeitsperre Zeitsperre deleted the output-url branch March 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration docs Improvements to documenation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants