Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled <Button> still reacts on presses visually #255

Closed
birdofpreyru opened this issue Aug 19, 2022 · 0 comments
Closed

Disabled <Button> still reacts on presses visually #255

birdofpreyru opened this issue Aug 19, 2022 · 0 comments
Labels
P2 Important. Nice to have improvements and optimizations. Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release.

Comments

@birdofpreyru
Copy link
Owner

Because its interaction selectors in the default SCSS theme are not removed by disabled class.
@birdofpreyru birdofpreyru added P2 Important. Nice to have improvements and optimizations. Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release. labels Aug 19, 2022
birdofpreyru added a commit that referenced this issue Aug 22, 2022
@birdofpreyru
[#255] Corrects default <Button> theme
a035c97 
- Ensures disabled buttons are not "visually pressed" when pressed.
- Ensures the focus highlight is applied to buttons in active (pressed)
state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important. Nice to have improvements and optimizations. Ready The bug / issue is fixed in some branch, but pending the prod release. Keep open until the release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@birdofpreyru