Add support for providing generic Swift types in a ValueProvider #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing all invocations to methods with generic return types to
be treated as returning the same type.
```swift
protocol MyProtocol {
func genericMethod<T>() -> T
}
let myMock = mock(MyProtocol.self)
given(myMock.genericMethod()) ~> "Foo"
given(myMock.genericMethod()) ~> true
let foo: String = (myMock as MyProtocol).genericMethod()
let bar: Bool = (myMock as MyProtocol).genericMethod()
// Invocation counts for both were incorrectly 2 instead of 1
verify(myMock.genericMethod()).returning(String.self).wasCalled()
verify(myMock.genericMethod()).returning(Bool.self).wasCalled()
```
Fix is to also store the actual type returned at runtime in order to
differentiate invocations to the same generic method.
andrewchang-bird
force-pushed
the
generic-value-provider
branch
2 times, most recently
from
ae4eca4
to
0480ca3
Compare
Due to limitations around Swift generics, this method relies on using
module-scoped extensions on the generic type to provide values.
```swift
extension Array: Providable {
public static func createInstance() -> Self? {
return Array()
}
}
// An empty array is registered for all specialized `Array` types
valueProvider.registerType(Array<Any>.self)
```
Also changes `ValueProvider` to use value semantics which improves
safety around preset value providers.
andrewchang-bird
force-pushed
the
generic-value-provider
branch
from
0480ca3
to
8a9d88d
Compare
ryanmeisters
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Stacked on #121)
Add support for providing generic Swift types in a ValueProvider
Due to limitations around Swift generics, this method relies on using module-scoped extensions on the generic type to provide values.
Also changes
ValueProviderto use value semantics which improves safety around preset value providers.