Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 1.11 #36

Closed
ajrbyers opened this issue Jul 31, 2017 · 1 comment
Closed

Upgrade to Django 1.11 #36

ajrbyers opened this issue Jul 31, 2017 · 1 comment
Assignees
Labels
enhancement Add or improve something on an existing feature security
Milestone

Comments

@ajrbyers
Copy link
Member

Upgrade to latest version of Django, this will require updating the django debug toolbar and updating dynamic sites to get rid of render_to_response.

This opportunity should be taken to upgrade all prerequisites.

/home/ajrbyers/.virtualenvs/janeway/src/dynamicsites/dynamicsites/middleware.py:
    3  from django.contrib.sites.models import Site
    4  from django.http import HttpResponsePermanentRedirect, Http404
    5: from django.shortcuts import render_to_response
    6  from django.utils.cache import patch_vary_headers
    7  from django.utils.http import urlquote
    .
  231                      if redirect_to:
  232                          cookies = response.cookies
  233:                         response = render_to_response(
  234                              'debug_toolbar/redirect.html',
  235                              {'redirect_to': redirect_to}

/home/ajrbyers/.virtualenvs/janeway/src/dynamicsites/dynamicsites/views.py:
    1  from django.http import Http404
    2: from django.shortcuts import render_to_response
    3  from django.template import RequestContext
    4  from django.contrib.sites.models import Site
    .
   16          'site':site
   17      }
   18:     return render_to_response('dynamicsites/site_info.html', args,
   19          context_instance=RequestContext(request))
@ajrbyers ajrbyers changed the title Upgrae to Django 1.11 Upgrade to Django 1.11 Jul 31, 2017
@ajrbyers ajrbyers self-assigned this Aug 2, 2017
@ajrbyers ajrbyers added enhancement Add or improve something on an existing feature security labels Aug 2, 2017
@ajrbyers ajrbyers added this to the janeway 1.0 milestone Aug 2, 2017
@ajrbyers
Copy link
Member Author

ajrbyers commented Aug 2, 2017

Upgrade complete.

@ajrbyers ajrbyers closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add or improve something on an existing feature security
Projects
None yet
Development

No branches or pull requests

1 participant