Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleo doc finaltouches #37

Merged
merged 19 commits into from
Oct 25, 2023
Merged

Cleo doc finaltouches #37

merged 19 commits into from
Oct 25, 2023

Conversation

crileonte
Copy link
Collaborator

No description provided.

@crileonte crileonte added the documentation Improvements or additions to documentation label Oct 24, 2023
@crileonte crileonte self-assigned this Oct 24, 2023
@pietropatelli pietropatelli marked this pull request as draft October 25, 2023 03:31
@pietropatelli
Copy link
Collaborator

The PR section of contributing still needs to be completed, as we do not yet have a template for PRs or a style guide, right?

Also, we could consider using forms for issues

@osirello
Copy link
Collaborator

Hi @pietropatelli , I added issue templates in the main - excellent proposal. Feel free to add a template for PR.

@pietropatelli pietropatelli marked this pull request as ready for review October 25, 2023 06:06
@pietropatelli
Copy link
Collaborator

Thanks for creating the templates in #39

osirello added a commit that referenced this pull request Oct 25, 2023
@osirello
Removing contributing as duplicate from #37
1407c18
@pietropatelli
Copy link
Collaborator

Note potentially conflicting changes with #39 in README.md

@pietropatelli pietropatelli self-requested a review October 25, 2023 07:25
@osirello osirello mentioned this pull request Oct 25, 2023
Draft
osirello
osirello approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@osirello osirello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code of conduct in #40

docs_src/code_of_conduct.md Outdated Show resolved Hide resolved
@osirello osirello merged commit 84ed91b into main Oct 25, 2023
@osirello osirello deleted the cleo_doc_finaltouches branch October 25, 2023 07:51
@pietropatelli pietropatelli mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osirello osirello osirello approved these changes

@pietropatelli pietropatelli Awaiting requested review from pietropatelli

Assignees

@crileonte crileonte

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crileonte @pietropatelli @osirello