Skip to content

Commit

Permalink
Add param names to DataflowRef and DataflowInfo
Browse files Browse the repository at this point in the history
  • Loading branch information
sosna committed May 13, 2024
1 parent b7f45e4 commit bbca1ea
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 29 deletions.
26 changes: 14 additions & 12 deletions src/pysdmx/fmr/fusion/dataflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,13 @@ class FusionDataflowRef(Struct, frozen=True, rename={"agency": "agencyId"}):
def to_model(self) -> DataflowRef:
"""Converts a FusionDataflowRef to a standard dataflow ref."""
return DataflowRef(
self.id,
self.agency,
self.names[0].value if self.names else None,
self.descriptions[0].value if self.descriptions else None,
self.version,
id=self.id,
agency=self.agency,
name=self.names[0].value if self.names else None,
description=(
self.descriptions[0].value if self.descriptions else None
),
version=self.version,
)


Expand Down Expand Up @@ -80,12 +82,12 @@ def to_model(
)
)[0]
return DataflowInfo(
df.id,
components,
Agency(df.agency),
df.names[0].value,
df.descriptions[0].value if df.descriptions else None,
df.version,
prvs,
id=df.id,
components=components,
agency=Agency(df.agency),
name=df.names[0].value,
description=df.descriptions[0].value if df.descriptions else None,
version=df.version,
providers=prvs,
dsd_ref=df.dataStructureRef,
)
2 changes: 1 addition & 1 deletion src/pysdmx/fmr/fusion/org.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class FusionProviderScheme(Struct, frozen=True):

def __get_df_ref(self, ref: str) -> DataflowRef:
a = parse_urn(ref)
return DataflowRef(a.id, a.agency, version=a.version)
return DataflowRef(id=a.id, agency=a.agency, version=a.version)

def to_model(
self, pas: Sequence[FusionProvisionAgreement]
Expand Down
24 changes: 12 additions & 12 deletions src/pysdmx/fmr/sdmx/dataflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ class JsonDataflowRef(Struct, frozen=True, rename={"agency": "agencyID"}):
def to_model(self) -> DataflowRef:
"""Converts a JsonDataflowRef to a standard dataflow ref."""
return DataflowRef(
self.id,
self.agency,
self.name,
self.description,
self.version,
id=self.id,
agency=self.agency,
name=self.name,
description=self.description,
version=self.version,
)


Expand Down Expand Up @@ -75,13 +75,13 @@ def to_model(
)
)[0]
return DataflowInfo(
df.id,
components,
Agency(df.agency),
df.name,
df.description,
df.version,
prvs,
id=df.id,
components=components,
agency=Agency(df.agency),
name=df.name,
description=df.description,
version=df.version,
providers=prvs,
dsd_ref=df.structure,
)

Expand Down
2 changes: 1 addition & 1 deletion src/pysdmx/fmr/sdmx/org.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class JsonDataProviderScheme(Struct, frozen=True):

def __get_df_ref(self, ref: str) -> DataflowRef:
a = parse_urn(ref)
return DataflowRef(a.id, a.agency, version=a.version)
return DataflowRef(id=a.id, agency=a.agency, version=a.version)

def to_model(
self, pas: Sequence[JsonProvisionAgreement]
Expand Down
2 changes: 1 addition & 1 deletion tests/model/test_category.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_default(id):

def test_full_instantiation(id, name, desc):
cats = [Category(id="chld", name="Child")]
flows = [DataflowRef("EXR", "BIS")]
flows = [DataflowRef(id="EXR", agency="BIS")]

c = Category(
id=id, name=name, description=desc, categories=cats, dataflows=flows
Expand Down
4 changes: 2 additions & 2 deletions tests/model/test_organisation.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ def contact():

@pytest.fixture()
def dataflows():
df1 = DataflowRef("DF1", "TEST")
df2 = DataflowRef("DF2", "Also TEST")
df1 = DataflowRef(id="DF1", name="TEST", agency="T1")
df2 = DataflowRef(id="DF2", name="Also TEST", agency="T1")
return [df1, df2]


Expand Down

0 comments on commit bbca1ea

Please sign in to comment.