SDMX IM base classes #27
Conversation
…o keep former structure. Adapted tests to use kwargs to ensure they work fine with new class model.
|
@sosna @stratosn FYI I made several changes to the tests to use kwargs giving the fact that we are adding many class attributes (like annotations) to ensure we are able to set these attributes correctly. Moreover I rolled back the changes on items to use codes/concepts and on maintainer to use agency (just like the former class structure. Please start reviewing the updated code and assess the impact on the tools that use them. |
…ther classes. Added DEV_checks file to write all commands necessary for good development practices (in Markdown, for now...) Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
… Added convenience methods for concepts and codes. Removed hierarchy on Item (no parent or children). Added Organisation superclass. Modified Category to inherit from Item. Modified all necessary serializers and deserializers to ensure all functionality is maintained. Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
|
@sosna @stratosn FYI The parts that may break compatibility with previous versions are the changes between codes/concepts/categories and items (ItemScheme objects need to be initialised with items instead of codes/concepts/categories). As we agreed yesterday the codes/concepts/categories in ItemScheme should be a getter only, therefore they are not included in the class initialization. Please review this. I have already changed the internal serializers and a couple of tests to ensure everything works fine. |
There was a problem hiding this comment.
Hi @javihern98. I have reviewed the PR and made a few comments (all minor). It looks very good and we are going in the right direction, I believe 😊
…ing of categories method. Added omit_defaults to category.py Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
…ult id. Added default value for agency as "" (pending #34). Changed tests that were not previously using keyword arguments. Added kw_only to AnnotableArtefact and all subclasses. Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
Discussion over #25