Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post init validation checks #36

Merged
merged 4 commits into from
May 13, 2024
Merged

Add post init validation checks #36

merged 4 commits into from
May 13, 2024

Conversation

sosna
Copy link
Collaborator

@sosna sosna commented May 3, 2024 •
edited
Loading

Post init validation checks have been added to:

  • Annotations, to make sure at least one property is set
  • Maintainable artefacts, to make sure the agency is set

Close #32
Close #34

javihern98
javihern98 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a minor improvement on a general method to check if the class is completely empty.

src/pysdmx/model/__base.py Show resolved Hide resolved
@sosna sosna merged commit 02d7fbe into develop May 13, 2024
14 checks passed
@sosna sosna deleted the post_init_checks branch May 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javihern98 javihern98 javihern98 approved these changes

@stratosn stratosn Awaiting requested review from stratosn

@antonio-olleros antonio-olleros Awaiting requested review from antonio-olleros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add post init check to Agency in MaintainableArtefact Add post init check to Annotation
2 participants
@sosna @javihern98