Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 metadata writer on sdmx ml #41

Merged
merged 10 commits into from
May 17, 2024
Merged

40 metadata writer on sdmx ml #41

merged 10 commits into from
May 17, 2024

Conversation

javihern98
Copy link
Contributor

@javihern98 javihern98 commented May 15, 2024 •
edited
Loading

This pull request adds for the first time the Writing on XML feature on pysdmx in Item and ItemScheme classes (and superclasses).

Summary:

  • Added writer function to introduce a specific dictionary (Message Content, to be implemented afterwards). This is divided in two modules, the public write module and the internal __writer_aux module, for better maintainability and reusability.
  • Added Header class with some default values (where minOccurs is 0 in SDMX-ML, we leave it as None)

Closes #40

@javihern98
Initial writing methods for metadata in SDMX-ML. Added enums for Mess…
c9a7aed 
…age Type and Action.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
@javihern98
Added _to_XML methods to Item and ItemScheme. Added also these method…
3da08ac 
…s to superclasses. Added auxiliary methods to writer_aux.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
@javihern98
Added tests for XML writers. Commented unused data writing methods. A…
cc3e06b 
…dded basic Header class.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
@javihern98 javihern98 requested a review from sosna May 15, 2024 11:20
@javihern98 javihern98 linked an issue May 15, 2024 that may be closed by this pull request
Metadata writer on SDMX-ML #40
Closed
@javihern98
Refactor code to add io module (Xavier suggestion). Refactored code t…
8acb5b6 
…o delete _to_XML methods and have the base package clean. Moved Header class to message.py.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
sosna
sosna reviewed May 16, 2024
View reviewed changes
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
src/pysdmx/io/xml/sdmx_two_one/writer/__write_aux.py Outdated Show resolved Hide resolved
src/pysdmx/io/xml/sdmx_two_one/writer/__write_aux.py Outdated Show resolved Hide resolved
src/pysdmx/io/xml/sdmx_two_one/writer/metadata_writer.py Outdated Show resolved Hide resolved
src/pysdmx/io/xml/sdmx_two_one/writer/metadata_writer.py Outdated Show resolved Hide resolved
src/pysdmx/io/xml/sdmx_two_one/writer/metadata_writer.py Outdated Show resolved Hide resolved
javihern98 and others added 4 commits May 16, 2024 11:50
@javihern98
Added double quotes in all xml files (better compatibility and readab…
71869a6 
…ility). Changed file structure.

Changed test value on Header to boolean. Changed MessageType.Metadata to MessageType.Structure.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
@javihern98
Refactor tests on writers to io module. Set receiver, source and data…
3333945 
…set_action as optional on Header.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
@javihern98
Moved MessageType to io.xml.enums.
dd2f6cd 
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
@sosna
Merge branch 'develop' into 40-metadata-writer-on-sdmx-ml
3f4375a
sosna
sosna reviewed May 17, 2024
View reviewed changes
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
@javihern98
Changed default values on Header. Added test for generated Header wit…
ef582a6 
…h defaults.

Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
sosna
sosna reviewed May 17, 2024
View reviewed changes
src/pysdmx/model/message.py Outdated Show resolved Hide resolved
@javihern98
Copy link
Contributor Author

Ready for final review @sosna @stratosn

sosna
sosna approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@sosna sosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @javihern98!

@javihern98 javihern98 merged commit b34657f into develop May 17, 2024
14 checks passed
@javihern98 javihern98 deleted the 40-metadata-writer-on-sdmx-ml branch May 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosna sosna sosna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata writer on SDMX-ML
2 participants
@javihern98 @sosna