50 xml parsers for data reading #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 21, 2024 12:31
…r directoy done. Flake8: Only one error left related to the complex of __reading_generic_series (12).
…l-parsers-for-data-reading # Conflicts: # poetry.lock # pyproject.toml # src/pysdmx/io/xml/sdmx21/reader/__init__.py
…ed data_read for better readability. Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
…ed data_read for better readability. Added tests. Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
…ads a big file. Modified __extract_structure function from data_read
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
…data. Coverage stills indicating that there are three lines of code with no use. Created a new load big file test with new bis_der_50500.xml file.
… into 50-xml-parsers-for-data-reading # Conflicts: # tests/io/xml/sdmx21/reader/test_reader.py
…data. Coverage stills indicating that there is one line of code with no use. Create a new load big file test with new bis_der_50500.xml file.
…ributes from dedicated test. Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
…l-parsers-for-data-reading # Conflicts: # poetry.lock
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
|
@sosna This PR includes a temporary dataset class to be replaced once CSV parsers are also included and discussions have been made, just to ensure all functionality is consistent to what we have in SDMXthon |
sosna
reviewed
Jul 9, 2024
…nique_id and used parse_urn. Removed handlers file (redundant). Removed commented code. Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
… into 50-xml-parsers-for-data-reading
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
sosna
approved these changes
Jul 9, 2024
…l-parsers-for-data-reading # Conflicts: # poetry.lock
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added data parsers for SDMX-ML 2.1 files.
This PR adds a dummy class DataSet that will be modified afterwards, once agreed on the functionality that this class will provide, but currently it is necessary to ensure the basic elements are correctly implemented.