onl: add packagegroups and split out platform libraries into own packages #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2023
ideaship
reviewed
Nov 1, 2023
Add and use packagegroups to group ONL platform support for each supported platform, to not let the list of kernel modules grow endlessly. This also makes it easier to add or remove platform support in the future. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Instead of having all all platform libraries included in the main onl package, move them into their own packages so the onl package only includes onlpd and its default libraries. Add the generated platform library packages to the appropriate platform support packagroups. This also adds an implicit dependency for the onl package via the libonlp-* package to the machines, which was missing until now. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_onl_split_libs
branch
from
3d64721
to
f1e15e9
Compare
ideaship
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better compartmentalize the ONL platform support parts, add packagegroups for each supported platform, and split out the platform libraries from the main onl package.
This will allow adding more platforms to build, but not include in the image to make it easier to lay groundwork for adding new platform support in the future.