Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onl: allow building more platforms #147

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

KanjiMonster
Copy link
Collaborator

@KanjiMonster KanjiMonster commented Jan 19, 2024

To make it easier adding new platform support make it optional to build untested platforms (which are not included in the image).

This way these can be then installed on the device via opkg and and any further changes can be done on the device.

By default, do not build these platforms, but we may chose to do that for nightly builds.

Since building more platforms means needing more fixes, consolidate the linux 6.1 API update patches into one, and pass appropriate build options to ignore some warnings instead of silencing in the code, allowing us to reduce the amount of patches needed further.

Copy link
Contributor

@ideaship ideaship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MR contains three commits with different subject matters, of which only one is mentioned in the PR description.

For the commit "onl: allow building more platforms", please add some documentation of how these new variables are meant to be used.

@KanjiMonster
Copy link
Collaborator Author

For the commit "onl: allow building more platforms", please add some documentation of how these new variables are meant to be used.

PACKAGECONFIG is a standard Yocto variable (name), I didn't expect to have to explain what this is or how to use it.

But if it makes you happy I can add the link to the docs in the commit.

@ideaship
Copy link
Contributor

I was hoping for something like: if you want to use this cool new feature, here's how you could do it. I like having such information in the commit message, even though there are other places for documentation. But maybe you are right. Everybody who can build BISDN Linux can figure this out.

Instead silencing each instance of a ignored result, disable treating it
as an error and drop all patches modifying code.

All we do is just ignoring the result anyway, so we don't lose anything
by disabling the error.

Keep the patches that actually do some error checking in these cases
though.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Replace individual module update patches with patches updating all
drivers in the tree.

No functional changes apart from context changes due to reordering of
patches.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Add PACKAGECOFIG[1] support for optionally building more platforms:

 - "unsupported" - buildable, but untested
 - "broken" - does not build (mostly as "known broken" list)

Due to the way getVar works, we need to define the appropriate lists
even when they are empty.

By default stay at the supported/tested level.

Broken for now also includes platforms that technically build, but
aren't handled by our recipe correctly, as it assumes all platforms have
modules and a platform library, which isn't true for some platforms.

[1] https://docs.yoctoproject.org/ref-manual/variables.html#term-PACKAGECONFIG

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
@ideaship ideaship merged commit 133e060 into main Feb 2, 2024
1 check passed
@ideaship ideaship deleted the jogo_onl_more_platforms branch February 2, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants