Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for onie-bisdn-upgrade as non-root #124

Closed
Keno opened this issue Nov 16, 2022 · 2 comments · Fixed by #126
Closed

Better error message for onie-bisdn-upgrade as non-root #124

Keno opened this issue Nov 16, 2022 · 2 comments · Fixed by #126

Comments

@Keno
Copy link

Keno commented Nov 16, 2022

$ onie-bisdn-upgrade -y http://repo.bisdn.de/pub/onie/accton-as4610/onie-bisdn-accton-as4610-v4.8.2.bin enp0
Configuration file wrong or corrupted
$ cat /etc/fw_env.config
# MTD device name       Device offset   Env. size       Flash sector size
/dev/mtd2               0x00000000      0x00002000         0x00010000

This is a vanilla install from the 4.8.1 image.

@Keno
Copy link
Author

Keno commented Nov 16, 2022

Ah, whoops, I wasn't root. So, I guess the ask here is for a better error message.

@Keno Keno changed the title onie-bisdn-upgrade complaining about corrupted config file Better error message for onie-bisdn-upgrade as non-root Nov 16, 2022
@KanjiMonster
Copy link
Contributor

I totally agree here.

KanjiMonster added a commit that referenced this issue Nov 17, 2022
The utilities need root privileges, so we should make sure we have them
before attempting anything, else we just print confusing error messages.

Fixes #124.

Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants