Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No UserAgent on windows implants #1584

Closed
C-Sto opened this issue Feb 27, 2024 · 0 comments · Fixed by #1637
Closed

No UserAgent on windows implants #1584

C-Sto opened this issue Feb 27, 2024 · 0 comments · Fixed by #1637
Labels
bug Something isn't working

Comments

@C-Sto
Copy link
Contributor

C-Sto commented Feb 27, 2024

Describe the bug
Implants generated don't appear to have a useragent set. Tracked it down to:
https://github.com/BishopFox/sliver/blame/dc93d054a9e68644203673a48c9b669683e43cb4/server/generate/binaries.go#L485

which should be able to be resolved by returning like return pbC2Implant.UserAgent instead.

This causes the wininet driver specifically to not do any network comms, as it rejects the header being added.

To Reproduce
Steps to reproduce the behavior:
on master branch, generate -G -b https://some-url-here/?driver=wininet -l -R --debug

run implant on windows machine, and see errors along the lines of

2024/02/27 00:36:42 sliver.go:151: [session] failed to establish connection: failed to add request headers: HttpAddRequestHeadersW: winapi error #12150

Expected behavior
an implant with a useragent

Desktop (please complete the following information):

  • OS: Windows
  • Version: All

Additional context
Unsure if that's the 'correct' way of fixing this bug

@moloch-- moloch-- added the bug Something isn't working label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants