Changed App shadow from filter to box-shadow #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowed darkening of background color, to improve lighthouse score
✅ Deploy Preview for fazeoid ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Here's lighthouse scores. Control is #79 deploy preview because production has different hosting which affect scores. Control: |
44100hertz
approved these changes
Sep 4, 2022
44100hertz
pushed a commit
that referenced
this pull request
Mar 6, 2023
allowed darkening of background color, to improve lighthouse score
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #70
Lighthouse says the labels directly on the background have too low of a contrast ratio. The text is near white, the background is
#0008. I think this is failing because the transparency is too low to guarantee contrast with any arbitrary background.Before the PR, the App's
filter: box-shadowwas drawing behind the transparent background, darkening the App. Lighthouse doesn't understand this, or assumes some browsers won't have support so it ignores filters. Replacing the filter with a box-shadow allows us to darken the background color with almost no visual change.