Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google Scholar #52

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Added Google Scholar #52

merged 5 commits into from
Oct 2, 2019

Conversation

sp1thas
Copy link
Contributor

@sp1thas sp1thas commented Oct 1, 2019


name: Engine Implementation
about: Implemented a new engine
title: 'Google Scholar Search Engine'
labels: 'engine', 'needs-review'
assignees: '@deven96', '@MeNsaaH'


Summary of steps Taken to implement the engine
A clear and concise description of what the engine is.

Ex. I added the Google Scholar engine, `googlescholar.py` to the `search_engine_parser/core/engines` directory and made the necessary imports.
This engine integrates Google Scholar search capabilities and returns titles, descriptions, links, files links, and results types

@deven96
Copy link
Member

deven96 commented Oct 1, 2019

Please resolve the conflicts, as @PalAditya changed the supported_engines.md with PR #51

@deven96 deven96 merged commit 8aefcfc into bisohns:dev Oct 2, 2019
@deven96
Copy link
Member

deven96 commented Oct 2, 2019

@all-contributors add @sp1thas for code and test

@allcontributors
Copy link
Contributor

@deven96

I've put up a pull request to add @sp1thas! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants