List BitCloud (BTDX)

[dalijolijo]

• Official project URL: https://bit-cloud.info
• Official block explorer URL: https://chainz.cryptoid.info/btdx

[blabno]

Applied Bisq codestyle. Please squash those commits.

[dalijolijo]

How can I squash the two commits in an easy way? Or do I have to create a new PullRequest?

[blabno]

git rebase -i HEAD^^
Then in the editor you change pick to fixup on the commits you want to merge with upper commit.

[dalijolijo]

squash commits done

[cbeams]

Hey @blabno, just a heads up that there's no need to have submitters squash commits if the only "extra commits" in question are review commits, e.g. the one here in which you applied Bisq's code style. It's actually useful to preserve such commits because it teaches others what the style deviation was.

What's not useful is having N partial commits that put together the original pull request. We always those three changes (Asset implementation, test and registration) to be atomic, and thus squashed if necessary. Thanks.

[dalijolijo]

What should I do now?

[cbeams]

utACK