Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

List Viacoin (VIA) #92

Closed
wants to merge 1 commit into from
Closed

Conversation

romanornr
Copy link

Official project URL: https://viacoin.org
Official block explorer URL: https://explorer.viacoin.org

third party block explorer URL: https://chainz.cryptoid.info/via/

Copy link
Collaborator

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK per comments

assertValidAddress("VdMPvn7vUTSzbYjiMDs1jku9wAh1Ri2Y1A");
assertValidAddress("EPt5g6LookySkqUNTwky24wTvzNrmKDP7r");
assertValidAddress("EVt5ypcAfiCccFrdHxPbFwnEo5WDevawM7");
//assertValidAddress("via1q95qlu98cpj23xy6w9tdnfn65n5vkpkey99g6wl"); bech32 for in the future
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the commented out coded.

@romanornr
Copy link
Author

I removed the comments.

@romanornr
Copy link
Author

Any update about this?

Copy link
Member

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Note that merges are on hold until the resolution of bisq-network/proposals#35. Please track that issue to stay up to date.

@cbeams
Copy link
Member

cbeams commented Sep 6, 2018

This repository has been moved into the 'assets' directory of the https://github.com/bisq-network/bisq repository. Please resubmit this pull request against that repository. See bisq-network/bisq-docs#84 for updated instructions. When submitting your pull request, please mention in the description (a) that this is a resubmission, (b) paste a link back to this original pull request, and (c) whether the original had already bee ACKed. Thank you.

@cbeams cbeams closed this Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants