This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Protobuffer exception handling #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We will add in the next commit a checked ProtobufferException so we want to distinguish from the runtime exception
- Use ProtobufferException for CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto) - Add raw PB data in case if an exception - log error if the encrypted data contains unknown PB data Note: We should refactor the resolvers with checked exceptions instead of the ProtobufferRuntimeException, but for the moment we leave that to not add too much complexity/risk for that release.
This was referenced Jun 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto)
Note: We should refactor the resolvers with checked exceptions instead
of the ProtobufferRuntimeException, but for the moment we leave that to
not add too much complexity/risk for that release.