This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Don't include assets with diff. network type #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Coins which got supported as base currencies have MAINNET, REGTEST and TESTNET entries. For the currency list that was not filtered so we got displayed 3 times DASH. We filter now for the selected network and exclude the other 2 Coin instances.
|
This probably only came up since we removed support for Dash and LTC as base currencies, right? Easiest thing to do would just remove these asset variants completely from bisq-assets. I’m mobile and only looked at this quickly though. |
|
No, it was just missing the filter for the other 2 network types in the currency list. Yes was considering also to remove the base currency support of those coins, but I think that is better to do with completely removing the support in all areas, which comes with more dev and test effort, so prefer to keep it. Does not hurt also and who knows when there is any reason to add support again we have all in place. |
|
Got it, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Coins which got supported as base currencies have MAINNET, REGTEST
and TESTNET entries. For the currency list that was not filtered so we
got displayed 3 times DASH. We filter now for the selected network and
exclude the other 2 Coin instances.