Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

Sync up with changes from voting branch #136

Merged
merged 1 commit into from Jul 11, 2018

Conversation

ManfredKarrer
Copy link
Member

There have been several changes in the voting branch (and api-integration) which I want to get into master to avoid that those branches run out of sync as well as to apply the improvements.
The main changes are:

  • The handling of persisted data in the p2p library (Change data persitence  bisq-p2p#8)
  • Improvements of the app setup to support API projects in headless mode as well as in mixed mode
  • Use custom TxBroadcaster class for better error handling

Beside that there are many smaller trivial improvements, fixes, refactoring and cleanups.

Changes in that project:

  • Add DaoOptionKeys.DAO_ACTIVATED option key
  • Add setupDevEnv, onApplicationStarted and startAppSetup to
    BisqExecutable
  • Rename BisqCoreApp to BisqHeadlessApp
  • Rename BisqCoreAppMain to BisqHeadlessAppMain
  • Add BisqSetupCompleteListener interface to BisqSetup
  • Remove @getterS from BisqSetup handlers
  • Change handling of setup complete handlers
  • Remove Objects.requireNonNull and use null checks instead
  • Add HeadlessApp class
  • Add TxBroadcaster class with improved error handling
  • Add TxBroadcastException and TxMalleabilityException
  • Use TxBroadcaster.Callback instead of FutureCallback
  • Remove Broadcaster
  • Fix wrong dust limit value in comments
  • Remove delay at updateBalance
  • Add AccountAgeWitnessStorageService and TradeStatistics2StorageService
  • Move BtcAddressValidator from desktop to core
  • Move old setup classes to bisq.core.app.misc

- Add DaoOptionKeys.DAO_ACTIVATED option key
- Add setupDevEnv, onApplicationStarted and startAppSetup to
BisqExecutable
- Rename BisqCoreApp to BisqHeadlessApp
- Rename BisqCoreAppMain to BisqHeadlessAppMain
- Add BisqSetupCompleteListener interface to BisqSetup
- Remove @getterS from BisqSetup handlers
- Change handling of setup complete handlers
- Remove Objects.requireNonNull and use null checks instead
- Add HeadlessApp class
- Add TxBroadcaster class with improved error handling
- Add TxBroadcastException and TxMalleabilityException
- Use TxBroadcaster.Callback instead of FutureCallback<Transaction>
- Remove Broadcaster
- Fix wrong dust limit value in comments
- Remove delay at updateBalance
- Add AccountAgeWitnessStorageService and TradeStatistics2StorageService
- Move BtcAddressValidator from desktop to core
- Move old setup classes to bisq.core.app.misc
@ManfredKarrer ManfredKarrer requested a review from sqrrm July 8, 2018 11:54
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I've been developing on top of these change for a while with no issues, but also haven't used some of the features so not a complete test.

@ripcurlx
Copy link
Member

ACK - see bisq-network/bisq#1601 (comment)

@ManfredKarrer ManfredKarrer merged commit b16e6ae into bisq-network:master Jul 11, 2018
@ManfredKarrer ManfredKarrer deleted the sync-with-voting branch August 14, 2018 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants