This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Fix tx broadcast issue #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the intended improvements with the broadcastToAllPeers flag did not work out. It is still unclear why but after more testing we still get issues with not receiving the broadcast success state. So we revert the whole code part which was introduced in January 2018. See: bisq-network/bitcoinj@5a6bc4a
ripcurlx
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was still not fixed with the latest changes as it has been shown in more tests. We reverted now completely the changes introduced in January 2018 as they did not improve the broadcast reliability but decreased it. It is still not understood why...
Depends on:
bisq-network/bisq-common#38