This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Small improvements in DAO code #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove check issuanceHeight <= txChainHeight as it is covered by getWeightedMeritAmount method and throws an exception.
- We want to avoid division with double and possible rounding issues and use long values instead. We get a resolution for 1 block with that approach. - Add tests and check for negative issuanceHeight
- Add sorting to BallotList - Add comments
sqrrm
approved these changes
Sep 4, 2018
| // We want a resolution of 1 block so we use the inverseAge and divide by maxAge afterwards to get the | ||
| // weighted amount | ||
| // We need to multiply first before we divide! | ||
| long weightedAmount = (amount * inverseAge) / maxAge; |
There was a problem hiding this comment.
I like this better than the previous calculations. Much easier to follow for the same effect.
| @@ -569,10 +572,14 @@ private void applyParamChange(Set<EvaluatedProposal> acceptedEvaluatedProposals, | |||
| if (list.size() == 1) { | |||
| applyAcceptedChangeParamProposal((ChangeParamProposal) list.get(0).getProposal(), chainHeight); | |||
| } else if (list.size() > 1) { | |||
| log.warn("There have been multiple winning param change proposals with the same item. " + | |||
| "This is a sign of a social consensus failure. " + | |||
| "We treat all requests as failed in such a case."); | |||
There was a problem hiding this comment.
I think this is correct, with a social failure it's unsafe to continue. I don't think this is an attack vector since it needs more than 50% of votes attacking, which is already a bigger issue in itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.