Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of currencies in market/trades view #1591

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Fix sorting of currencies in market/trades view #1591

merged 1 commit into from
Jun 27, 2018

Conversation

ManfredKarrer
Copy link
Member

@ManfredKarrer ManfredKarrer commented Jun 27, 2018

Currencies in the markets/trades view are sorted by number of trades (if selected that option in
preferences). The PriorityQueue used for the list do not apply the
sorting of the list (only sorts when taking an element out). We use a
ArrayList instead to apply sorting.

Trades are sorted by number of trades (if selected that option in
preferences). The PriorityQueue used for the list do not apply the
sorting of the list (only sorts when taking an element out). We use a
ArrayList instead to apply sorting.
@ManfredKarrer ManfredKarrer changed the title Fix sorting of trades Fix sorting of currencies in market/trades view Jun 27, 2018
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit aecbb71 into bisq-network:master Jun 27, 2018
@ManfredKarrer ManfredKarrer deleted the fix-trades-sorting-bug branch August 14, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants