Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the requests in issue #6 for the /trades api, namely:
note that volume could be calculated previously by multiplying price*amount, but the floating point multiplication often leaves numbers like 1.999999999 instead of 2.
note also that primary currency does not mean basecurrency aka bitcoin. Rather, primary currency is always the currency that is 2nd in the market identifer, eg xmr_btc, btc is primary. or btc_usd, usd is primary. The rule in bisq is that fiat currencies are always primary against basecurrency (btc), and basecurrency is primary against other cryptocurrencies. So if one wants to know amount of btc traded for any given market, one would use this logic:
I needed to link to PaymentMethod.java in the apidoc, and it was escaping all html entities, so I added a capability to detect markdown-style links in an API description or notes.
Sample Response ( from the updated apidoc )