Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers to improve security #144

Merged
merged 1 commit into from Mar 8, 2019
Merged

Add headers to improve security #144

merged 1 commit into from Mar 8, 2019

Conversation

ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Mar 8, 2019 •
edited

@ripcurlx ripcurlx changed the title Add headers security configuration also for netlify Add headers to improve security Mar 8, 2019
@ripcurlx
Copy link
Member Author

ripcurlx commented Mar 8, 2019

It is configured as described in https://www.netlify.com/docs/headers-and-basic-auth/. But I don't see it in the test build.

@ripcurlx
Copy link
Member Author

ripcurlx commented Mar 8, 2019

I do see the correct headers on sub sites (e.g. vision), but it should be actually also configured for the root as well.

@ripcurlx
Copy link
Member Author

ripcurlx commented Mar 8, 2019

To use https://infosec.mozilla.org/guidelines/web_security#content-security-policy is a little bit more effort as I would need to check for all in-line scripts and do lots of testing not to break anything. Will be a next step.

@m52go
Copy link
Contributor

m52go commented Mar 8, 2019

ACK

@ripcurlx ripcurlx merged commit a664c28 into bisq-network:master Mar 8, 2019
@ripcurlx ripcurlx mentioned this pull request Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ripcurlx @m52go